moby-openapi: Add more fixups

Upstream is using more instances of types that can't be validated; rather
than listing it all individually, walk the definition and find all
instances of types known to have issues and do fixups directly.

Signed-off-by: Mark Yen <mark.yen@suse.com>
(cherry picked from commit b44b4a2)

Author: mook-as

scripts/dependencies/moby-openapi.ts

@@ -38,19 +38,46 @@ export class MobyOpenAPISpec extends GlobalDependency(VersionedDependency) {
     for (const key of Object.keys(contents.definitions ?? {}).filter(k => /^Plugin./.test(k))) {
       delete contents.definitions[key]?.['x-go-name'];
     }
-    // This forces a go type that isn't defined; delete the override and just
-    // use strings instead.
-    if (_.get(contents, 'definitions.Plugin.properties.Config.properties.Interface.properties.Types.items.x-go-type.type') === 'CapabilityID') {
-      delete contents.definitions.Plugin.properties.Config.properties.Interface.properties.Types.items['x-go-type'];
-    }
-    // Overriding the `dateTime` to `time.Time` means we can't use the validation function.
-    if (_.get(contents, 'definitions.Network.properties.Created.x-go-type.import.package') === 'time') {
-      _.set(contents, 'definitions.Network.properties.Created.x-go-type.hints.noValidation', true);
-    }
-    // Having the x-go-type here confuses swagger.
-    if (_.has(contents, 'definitions.IPAMStatus.properties.Subnets.x-go-type')) {
-      delete _.get(contents, 'definitions.IPAMStatus.properties.Subnets')['x-go-type'];
-    }
+
+    // Some type overrides end up with errors, override them here:
+    // noTypeOverride: This type does not actually exist in go, delete the override.
+    // noValidate: This does not implement the .Validate() method; add a 'noValidation' hint.
+    const perTypeActions: Record<string, 'noTypeOverride' | 'noValidate'> = {
+      'net/netip.Addr':           'noValidate',
+      'net/netip.Prefix':         'noValidate',
+      'time.Time':                'noValidate',
+      'undefined.int':            'noValidate',
+      'undefined.CapabilityID':   'noTypeOverride', // This type is not defined anywhere.
+      'undefined.SubnetStatuses': 'noTypeOverride', // This type is not defined anywhere.
+    };
+
+    (function checkTypes(obj: object, prefix = '') {
+      for (const [k, v] of Object.entries(obj)) {
+        if (k === 'x-go-type') {
+          const typeName = `${ v.import?.package }.${ v.type }`;
+          if (typeName in perTypeActions) {
+            switch (perTypeActions[typeName]) {
+            case 'noTypeOverride':
+              console.log(`\x1B[34m${ prefix } has invalid type ${ typeName }, removing.\x1B[0m`);
+              delete (obj as any)[k];
+              break;
+            case 'noValidate':
+              console.log(`\x1B[34m${ prefix } has type ${ typeName }, disabling validation.\x1B[0m`);
+              _.set(v, 'hints.noValidation', true);
+              break;
+            }
+          } else {
+            console.log(`\x1B[34m${ prefix } has unknown type ${ typeName }, ignoring.\x1B[0m`);
+          }
+        } else if (_.isPlainObject(v)) {
+          checkTypes(v, `${ prefix }.${ k }`.replace(/^\./, ''));
+        } else if (Array.isArray(v)) {
+          for (const [i, element] of Object.entries(v)) {
+            checkTypes(element, `${ prefix }[${ i }]`);
+          }
+        }
+      }
+    })(contents);
 
     await fs.promises.writeFile(modifiedPath, yaml.stringify(contents), 'utf-8');