Skip to content

Commit c0a56a9

Browse files
committed
Update: address review comments
#882 (comment) #882 (comment) Signed-off-by: Mark Yen <mark.yen@suse.com>
1 parent 30b3a37 commit c0a56a9

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/main/update/LonghornProvider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,11 @@ export async function hasQueuedUpdate(): Promise<boolean> {
138138
const stagedVersion = semver.parse(cache.release.tag, { loose: true });
139139

140140
if (!currentVersion || !stagedVersion) {
141-
console.log(`Error parsing staged versions: ${ currentVersion } -> ${ stagedVersion }`);
141+
console.log(`Error parsing staged versions: ${ currentVersion ?? '<none>' } -> ${ stagedVersion ?? '<none>' }`);
142142

143143
return false;
144144
}
145-
if (currentVersion.compare(stagedVersion) >= 0) {
145+
if (semver.gte(currentVersion, stagedVersion)) {
146146
console.log(`Staged version ${ stagedVersion } not greater than current version ${ currentVersion }, skipping.`);
147147

148148
return false;

0 commit comments

Comments
 (0)