Skip to content

Commit f5c1751

Browse files
authored
Merge pull request #681 from mattfarina/fix-667
Remove code causing node roles to be deleted
2 parents 6e09bc2 + d869fcb commit f5c1751

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

src/k8s-engine/client.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -533,20 +533,4 @@ export class KubeClient extends events.EventEmitter {
533533
});
534534
});
535535
}
536-
537-
/**
538-
* Clean up obsolete nodes that match a predicate.
539-
* @param predicate A function that returns true if a node should be removed.
540-
*/
541-
async cleanupNodes(predicate: (node: k8s.V1Node) => boolean) {
542-
const { body: nodeList } = await this.coreV1API.listNode();
543-
const promises = nodeList
544-
.items
545-
.filter(predicate)
546-
.map(node => node.metadata?.name)
547-
.filter(defined)
548-
.map(nodeName => this.coreV1API.deleteNode(nodeName));
549-
550-
return await Promise.all(promises);
551-
}
552536
}

src/k8s-engine/lima.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -755,10 +755,6 @@ export default class LimaBackend extends events.EventEmitter implements K8s.Kube
755755
this.emit('service-changed', services);
756756
});
757757

758-
// We need to remove obsolete nodes because we renamed the VM; otherwise
759-
// they get stuck forever. No need to wait for the result.
760-
this.client.cleanupNodes(node => node.metadata?.name === 'lima-rancher-desktop');
761-
762758
this.activeVersion = desiredShortVersion;
763759
this.currentPort = this.#desiredPort;
764760
this.emit('current-port-changed', this.currentPort);

0 commit comments

Comments
 (0)