Merge pull request #220 from rancher-sandbox/211b-missing-windows-images

Show images on Windows

Author: ericpromislow

background.ts

@@ -256,6 +256,10 @@ Electron.ipcMain.on('do-image-push', async(event, imageName, imageID, tag) => {
   event.reply('kim-process-ended', code);
 });
 
+Electron.ipcMain.handle('images-fetch', (event) => {
+  return imageManager.listImages();
+});
+
 Electron.ipcMain.on('k8s-state', (event) => {
   event.returnValue = k8smanager.state;
 });
@@ -332,8 +336,8 @@ Electron.ipcMain.on('k8s-versions', async() => {
   }
 });
 
-Electron.ipcMain.handle('service-fetch', async(event, namespace) => {
-  return await k8smanager?.listServices(namespace);
+Electron.ipcMain.handle('service-fetch', (event, namespace) => {
+  return k8smanager?.listServices(namespace);
 });
 
 Electron.ipcMain.handle('service-forward', async(event, service, state) => {

src/k8s-engine/client.ts

@@ -217,7 +217,7 @@ export class KubeClient extends events.EventEmitter {
    * @param {string} endpointName the name of an endpoint that controls ready pods.
    * @returns {Promise<k8s.V1Pod?>}
    */
-  protected async getActivePod(namespace: string, endpointName: string): Promise<k8s.V1Pod | null> {
+  async getActivePod(namespace: string, endpointName: string): Promise<k8s.V1Pod | null> {
     console.log(`Attempting to locate ${ endpointName } pod...`);
     // Loop fetching endpoints, until it matches at least one pod.
     let target: k8s.V1ObjectReference|undefined;

src/k8s-engine/kim.ts

@@ -27,6 +27,11 @@ export default class Kim extends EventEmitter {
   private showedStderr = false;
   private refreshInterval: ReturnType<typeof setInterval> | null = null;
   private currentCommand: string | null = null;
+  // During startup `kim images` repeatedly fires the same error message. Instead,
+  // keep track of the current error and give a count instead.
+  private lastErrorMessage = '';
+  private sameErrorMessageCount = 0;
+  private images: imageType[] = [];
 
   start() {
     this.stop();
@@ -42,7 +47,7 @@ export default class Kim extends EventEmitter {
 
   async runCommand(args: string[], sendNotifications = true): Promise<childResultType> {
     const child = spawn(resources.executable('kim'), args);
-    const result :childResultType = {
+    const result: childResultType = {
       stdout: '', stderr: '', code: 0
     };
 
@@ -58,13 +63,26 @@ export default class Kim extends EventEmitter {
       child.stderr.on('data', (data: Buffer) => {
         const dataString = data.toString();
 
-        console.log(dataString.replace(/([^\r])\n/g, '$1\r\n'));
         result.stderr += dataString;
         if (sendNotifications) {
           this.emit('kim-process-output', dataString, true);
         }
       });
       child.on('exit', (code: number, sig: string) => {
+        if (result.stderr) {
+          const timeLessMessage = result.stderr.replace(/\btime=".*?"/g, '');
+
+          if (this.lastErrorMessage !== timeLessMessage) {
+            this.lastErrorMessage = timeLessMessage;
+            this.sameErrorMessageCount = 1;
+            console.log(result.stderr.replace(/(?!<\r)\n/g, '\r\n'));
+          } else {
+            const m = /(Error: .*)/.exec(this.lastErrorMessage);
+
+            this.sameErrorMessageCount += 1;
+            console.log(`kim ${ args[0] }: ${ m ? m[1] : 'same error message' } #${ this.sameErrorMessageCount }\r`);
+          }
+        }
         result.code = code;
         if (code === 0) {
           resolve(result);
@@ -117,6 +135,10 @@ export default class Kim extends EventEmitter {
     return results;
   }
 
+  listImages(): imageType[] {
+    return this.images;
+  }
+
   async refreshImages() {
     try {
       const result: childResultType = await this.getImages();
@@ -129,7 +151,8 @@ export default class Kim extends EventEmitter {
       } else {
         this.showedStderr = false;
       }
-      this.emit('images-changed', this.parse(result.stdout));
+      this.images = this.parse(result.stdout);
+      this.emit('images-changed', this.images);
     } catch (err) {
       if (!this.showedStderr) {
         if (err.stderr && !err.stdout && !err.signal) {

src/k8s-engine/wsl.ts

@@ -13,6 +13,7 @@ import XDGAppPaths from 'xdg-app-paths';
 
 import { Settings } from '../config/settings';
 import DownloadProgressListener from '../utils/DownloadProgressListener';
+import resources from '../resources';
 import * as K8s from './k8s';
 import K3sHelper from './k3sHelper';
 
@@ -307,6 +308,38 @@ export default class WSLBackend extends events.EventEmitter implements K8s.Kuber
         this.emit('service-changed', services);
       });
       this.activeVersion = desiredVersion;
+
+      // Temporary workaround: ensure root is mounted as shared -- this will be done later
+      // Right now the builder pod needs to be restarted after the remount
+      // TODO: When this code is removed, make `client.getActivePod` protected again.
+      try {
+        await childProcess.exec('wsl --user root -d k3s mount --make-shared /');
+        console.log('Waiting for ensuring root is shared');
+        await util.promisify(setTimeout)(60_000);
+        await util.promisify(childProcess.execFile)(resources.executable('kim'), ['builder', 'install', '--force', '--no-wait']);
+        const startTime = Date.now();
+        const maxWaitTime = 120_000;
+        const waitTime = 3_000;
+
+        while (true) {
+          const currentTime = Date.now();
+
+          if ((currentTime - startTime) > maxWaitTime) {
+            console.log(`Waited more than ${ maxWaitTime / 1000 } secs, it might start up later`);
+            break;
+          }
+          // Find a working pod
+          const pod = await this.client.getActivePod('kube-image', 'builder');
+
+          if (pod?.status?.phase === 'Running') {
+            break;
+          }
+          await util.promisify(setTimeout)(waitTime);
+        }
+      } catch (e) {
+        console.log(`Failed to restart the kim builder: ${ e.message }.`);
+        console.log('The images page will probably be empty');
+      }
       this.setState(K8s.State.STARTED);
     } catch (ex) {
       this.setState(K8s.State.ERROR);

src/pages/Images.vue

@@ -20,7 +20,7 @@ export default {
     return {
       settings:      ipcRenderer.sendSync('settings-read'),
       state:         ipcRenderer.sendSync('k8s-state'),
-      images:   [],
+      images:        [],
     };
   },
 
@@ -35,6 +35,10 @@ export default {
       // TODO: put in a status bar
       this.$data.settings = settings;
     });
+    ipcRenderer.invoke('images-fetch')
+      .then((images) => {
+        this.$data.images = images;
+      });
   },
 
   methods: {