Skip to content

Updates & Refactors for k8s 1.32#644

Merged
alexandreLamarre merged 4 commits intorancher:mainfrom
mallardduck:k8s132
Feb 6, 2025
Merged

Updates & Refactors for k8s 1.32#644
alexandreLamarre merged 4 commits intorancher:mainfrom
mallardduck:k8s132

Conversation

@mallardduck
Copy link
Member

@mallardduck mallardduck commented Jan 14, 2025

Blocked by: #645
I will submit a version of this based of main after above is merged. This will ensure higher test coverage before the breaking upstream change is accounted for.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we can do this check here...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...it technically does similar to what this intended to do, just after transformer.TransformToStorage is called instead of before. Obviously before was better, but no longer an option (for) now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that because of those factors, this is a new change in dataflow/processing that non-encrypted restores used to skip, but will now run all the time. So ultimately this likely doesn't change too much at the end of the day, but is technically a new area that an error could come from.

@mallardduck mallardduck requested a review from jbiers February 5, 2025 22:23
@mallardduck mallardduck marked this pull request as ready for review February 5, 2025 22:56
@mallardduck mallardduck requested a review from a team as a code owner February 5, 2025 22:56
Copy link
Contributor

@alexandreLamarre alexandreLamarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump

The matrix k3s versions here to 1.30.X & 1.32.X

Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
@alexandreLamarre alexandreLamarre merged commit 337159c into rancher:main Feb 6, 2025
7 checks passed
@alexandreLamarre
Copy link
Contributor

Part of rancher/rancher#48832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants