Inconsistent default controller behaviour

[k0da]

I'm successfully using caapf, thanks for a great work.

Our use case:

• we create single clusterclass and multiple clusters tighten to it within single namespace (this pattern replicates across multiple namespaces).
• each namespace got gitrepo with default application set required to be deployed across all the clusters within a namespace (cert-man, cpi,csi, eso, extdns etc..)

New requirement:

• all CAPI provisioned nodes are tainted with karpenter.sh/controller
• we need fleet-agent to tolerate that taint and bootstrap cluster with default set of controllers (including karpenter)

I'm trying to add toleration as follows:

apiVersion: addons.cluster.x-k8s.io/v1alpha1
kind: FleetAddonConfig
metadata:
  name: fleet-addon-config
spec:
spec:
  cluster:
    agentTolerations:
      - key: "karpenter.sh/controller"
        operator: "Equal"
        effect: "NoSchedule"
        value: "true"

All good, but now selector and namespaceSelector are required, cool I can live with that:

spec:
  cluster:
    namespaceSelector: {}
    selector: {}

BUT now applyClassGroup is not true by default.

I wonder if using FleetAddonConfig does not have sane defaults aligned with a controller. Thanks