fix: properly format IPv6 addresses in server URLs#906
Open
Kristian-ZH wants to merge 1 commit into
Open
Conversation
hardys
suggested changes
May 20, 2026
Kristian-ZH
force-pushed
the
fix/ipv6-server-url-formatting
branch
from
cdb9f23 to
827c669
Compare
When provisioning nodes with IPv6 control plane endpoints, the bootstrap provider was generating invalid server URLs in the RKE2 configuration. Invalid format: https://fd12:3456:890b::250:6443 Correct format: https://[fd12:3456:890b::250]:6443 This fix uses the standard library net.JoinHostPort function which properly handles IPv6 bracket notation per RFC 3986. The function automatically wraps IPv6 addresses in brackets while leaving IPv4 addresses and hostnames unchanged. The fix is applied to all three server URL generation points: - Init control plane config - Join control plane config - Worker node config This eliminates the need for sed workarounds in user manifests. Fixes: Invalid IPv6 URL parsing in RKE2 bootstrap config Signed-off-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Kristian-ZH
force-pushed
the
fix/ipv6-server-url-formatting
branch
from
827c669 to
5282e21
Compare
anmazzotti
approved these changes
May 20, 2026
furkatgofurov7
approved these changes
May 26, 2026
Contributor
|
@Kristian-ZH hi, thanks for the change, however, the repository has required settings so that all commits must have verified signatures, otherwise we can't merge it. Please sign your commit, the change LGTM! |
salasberryfin
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When provisioning nodes with IPv6 control plane endpoints, the bootstrap provider was generating invalid server URLs in the RKE2 configuration.
Invalid format: https://fd12:3456:890b::250:6443
Correct format: https://[fd12:3456:890b::250]:6443
This fix adds a formatServerURL() helper function that:
The fix is applied to all three server URL generation points: