Add in-place updates e2e suite#910
Open
alexander-demicev wants to merge 3 commits into
Open
Conversation
Signed-off-by: Alex Demicev <alex.demicev@lambdal.com>
Signed-off-by: Alex Demicev <alex.demicev@lambdal.com>
Signed-off-by: Alex Demicev <alex.demicev@lambdal.com>
alexander-demicev
force-pushed
the
inplaceupdatestests
branch
from
6b9fdab to
a615527
Compare
furkatgofurov7
added
area/e2e-testing
anmazzotti
reviewed
May 26, 2026
anmazzotti
reviewed
May 26, 2026
anmazzotti
approved these changes
May 26, 2026
Contributor
anmazzotti
left a comment
anmazzotti
left a comment
There was a problem hiding this comment.
Nice work, thank you!
furkatgofurov7
approved these changes
May 26, 2026
Contributor
furkatgofurov7
left a comment
furkatgofurov7
left a comment
There was a problem hiding this comment.
Thanks a lot, nice work!
Contributor
Author
|
@furkatgofurov7 @anmazzotti can someone restart the lint job? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds e2e suite and test extension for in-place updates, I also uncovered some issues with the implementation. All code mostly follows kubeadm patterns.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #907, #908
Special notes for your reviewer:
Checklist: