refactor: remove console logs and clean up unused code in Harvester management components

Author: a110605

pkg/harvester-manager/list/harvesterhci.io.management.cluster.vue

@@ -53,8 +53,6 @@ export default {
   },
 
   async fetch() {
-    console.log('isRancherPrime=', isRancherPrime())
-    console.log('HARVESTER_REPO=', HARVESTER_REPO)
     const inStore = this.$store.getters['currentProduct'].inStore;
 
     const _hash = {
@@ -125,10 +123,8 @@ export default {
 
     harvester() {
       const extension = this.uiplugins?.find((c) => c.name === HARVESTER_CHART.name);
-      console.log('harvester extension=', extension);
       // if installed harvester ui extension, but no harvester repository, then we will show missing repository warning message
       const missingRepository = !!extension && !this.harvesterRepository;
-      console.log('harvester this.harvesterRepository=',this.harvesterRepository)
 
       const action = async(btnCb) => {
         const action = `${ !extension ? 'install' : 'update' }HarvesterExtension`;
@@ -209,18 +205,6 @@ export default {
       };
     },
 
-    // canCreateCluster() {
-    //   // we also check MANAGEMENT.CLUSTER (management.cattle.io.cluster) to avoid `View Virtualization Resource` role (introduced in Harvester RBAC) to create or manage the harvester cluster
-    //   const mgmtClusterSchema = this.$store.getters['management/schemaFor'](MANAGEMENT.CLUSTER);
-    //   const schema = this.$store.getters['management/schemaFor'](CAPI.RANCHER_CLUSTER);
-
-    //   const mgmtClusterCreate = !!mgmtClusterSchema?.collectionMethods?.find((x) => x.toLowerCase() === 'post');
-    //   console.log('mgmtClusterCreate=', mgmtClusterCreate);
-    //   const clusterCreate = !!schema?.collectionMethods?.find((x) => x.toLowerCase() === 'post');
-    //   console.log('clusterCreate=', clusterCreate);
-    //   return clusterCreate && mgmtClusterCreate;
-    // },
-
     rows() {
       return this.hciClusters
         .filter((c) => {
@@ -262,8 +246,6 @@ export default {
         if (isRancherPrime()) {
           return await getHelmRepositoryExact(this.$store, HARVESTER_REPO.gitRepo);
         } else {
-          console.log('getHarvesterRepository communityRepoRegexes=',communityRepoRegexes)
-          console.log('getHarvesterRepository HARVESTER_CATALOG_IMAGES=',HARVESTER_CATALOG_IMAGES)
           return await getHelmRepositoryMatch(this.$store, communityRepoRegexes, HARVESTER_CATALOG_IMAGES);
         }
       } catch (error) {

pkg/harvester-manager/models/harvesterhci.io.management.cluster.js

@@ -43,27 +43,30 @@ export default class HciCluster extends ProvCluster {
   // We do not allow users to edit Harvester clusters from Cluster Management, so we need to re-enable that action here.
   get _availableActions() {
     const out = super._availableActions;
-    if(!this.canCreateAndManageCluster){
+
+    if (!this.canCreateAndManageCluster) {
       const allowActions = ['goToViewYaml', 'download', 'viewInApi'];
+
       return out.filter((action) => allowActions.includes(action.action));
     }
 
     const edit = out.find((action) => action.action === 'goToEdit');
+
     if (edit) {
       edit.enabled = this.canEdit;
     }
 
     return out;
   }
 
-
   get canCreateAndManageCluster() {
     // we check MANAGEMENT.CLUSTER (management.cattle.io.cluster) to avoid standard user role to create or manage the harvester clusters.
     const mgmtClusterSchema = this.$rootGetters['management/schemaFor'](MANAGEMENT.CLUSTER);
     const schema = this.$rootGetters['management/schemaFor'](CAPI.RANCHER_CLUSTER);
 
     const mgmtClusterCreate = !!mgmtClusterSchema?.collectionMethods?.find((x) => x.toLowerCase() === 'post');
     const clusterCreate = !!schema?.collectionMethods?.find((x) => x.toLowerCase() === 'post');
+
     return clusterCreate && mgmtClusterCreate;
   }