Commit 5bbf48e
committed
Address PR review feedback
- Use ?? instead of || for count/length in StatusCard computed
- Add .filter((c) => c) to workload cards getter for null safety
- Initialize summaries.pods = null explicitly when no pod selector
- Use normalizedType in useResourceSummary dispatch for consistency1 parent 7627de0 commit 5bbf48e
3 files changed
Lines changed: 6 additions & 4 deletions
File tree
- shell
- components/Resource/Detail/Card
- StateCard
- StatusCard
- models
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
293 | 293 | | |
294 | 294 | | |
295 | 295 | | |
296 | | - | |
| 296 | + | |
297 | 297 | | |
298 | 298 | | |
299 | 299 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
| 109 | + | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
595 | 595 | | |
596 | 596 | | |
597 | 597 | | |
| 598 | + | |
| 599 | + | |
598 | 600 | | |
599 | 601 | | |
600 | 602 | | |
| |||
931 | 933 | | |
932 | 934 | | |
933 | 935 | | |
934 | | - | |
| 936 | + | |
935 | 937 | | |
936 | 938 | | |
0 commit comments