improve clusterLabels PO to avoid loose selector usage

Author: a-arias

cypress/e2e/po/pages/fleet/fleet.cattle.io.cluster.po.ts

@@ -66,8 +66,10 @@ export class FleetClusterDetailsPo extends BaseDetailPagePo {
     return this.self().get('.btn').contains('Create App Bundle');
   }
 
-  clusterLabels(): Cypress.Chainable {
-    return this.self().find('.tag-data');
+  hasClusterLabel(key: string, value: string) {
+    return this.self()
+      .find('.tag-data')
+      .contains(`${ key }: ${ value }`);
   }
 }
 

cypress/e2e/tests/pages/fleet/fleet-clusters.spec.ts

@@ -127,7 +127,7 @@ describe('Fleet Clusters - bundle manifests are deployed from the BundleDeployme
     fleetClusterDetailsPage.clusterTabs().clickTabWithSelector('[data-testid="btn-applications"]');
 
     // check cluster labels
-    fleetClusterDetailsPage.clusterLabels().contains('foo: bar').scrollIntoView().should('be.visible');
+    fleetClusterDetailsPage.hasClusterLabel('foo', 'bar').should('be.visible');
 
     // check state
     fleetClusterDetailsPage.appBundlesList().resourceTableDetails(gitRepo, 1).contains('Active');

package.json

@@ -155,7 +155,7 @@
     "@cypress/grep": "3.1.5",
     "@cypress/vue": "5.0.5",
     "@cypress/webpack-dev-server": "3.4.1",
-    "@percy/cli": "^1.31.11",
+    "@percy/cli": "1.31.11",
     "@percy/cypress": "3.1.6",
     "@types/copy-webpack-plugin": "5.0.3",
     "@types/dompurify": "3.0.5",