Validation for duplicate pool names (#17512)

* add duplicate pool names validation

* fix case sensitive validation issue + unit tests

* fix re-rendering issue on the vertical tabs

* fix not using translation key

* show duplicate pool name error without requiring field interaction

---------

Co-authored-by: Mo Mesgin <mmesgin@Mos-M2-MacBook-Pro.local>

Author: momesgin

shell/assets/translations/en-us.yaml

@@ -2341,7 +2341,9 @@ cluster:
       etcdControlPlaneWarning: We don't recommend using Autoscaler with machine pools that have the etcd or Control Plane roles. You can modify the yaml if you want to override the current value.
     name:
       label: Pool Name
+      notNamed: (Not Named)
       placeholder: A random one will be generated by default
+      unique: Pool names should be unique
     nodeTotals:
       label:
         controlPlane: '{count} Control Plane'

shell/edit/provisioning.cattle.io.cluster/__tests__/MachinePool.test.ts

@@ -0,0 +1,104 @@
+import { shallowMount } from '@vue/test-utils';
+import MachinePool from '@shell/edit/provisioning.cattle.io.cluster/tabs/MachinePool.vue';
+
+const TRANSLATION_KEY = '%cluster.machinePool.name.unique%';
+
+function createPool(name: string, { remove = false } = {}) {
+  return {
+    id:     `pool-${ name }`,
+    remove,
+    create: false,
+    update: true,
+    pool:   {
+      name,
+      etcdRole:         false,
+      controlPlaneRole: false,
+      workerRole:       true,
+      quantity:         1,
+    },
+    config: null,
+  };
+}
+
+function mountMachinePool(currentPool: ReturnType<typeof createPool>, allPools: ReturnType<typeof createPool>[]) {
+  return shallowMount(MachinePool, {
+    props: {
+      value:          currentPool,
+      mode:           'create',
+      provider:       'custom',
+      idx:            0,
+      machinePools:   allPools,
+      poolId:         currentPool.id,
+      poolCreateMode: true,
+    },
+    global: {
+      mocks: {
+        $store: {
+          getters: {
+            'i18n/t':                                   (key: string) => key,
+            'i18n/exists':                              () => false,
+            'type-map/hasCustomMachineConfigComponent': () => false,
+            'type-map/importMachineConfig':             () => null,
+            'features/get':                             () => false,
+          },
+          dispatch: jest.fn(),
+        },
+      },
+      stubs: {
+        LabeledInput:    true,
+        Checkbox:        true,
+        Taints:          true,
+        KeyValue:        true,
+        AdvancedSection: true,
+        Banner:          true,
+        UnitInput:       true,
+      },
+    },
+  });
+}
+
+describe('component: MachinePool', () => {
+  describe('uniquePoolName validation', () => {
+    it('should return undefined when the name is empty', () => {
+      const pool = createPool('');
+      const wrapper = mountMachinePool(pool, [pool]);
+
+      expect(wrapper.vm.fvExtraRules.uniquePoolName('')).toBeUndefined();
+    });
+
+    it('should return undefined when the pool name is unique', () => {
+      const pool1 = createPool('pool1');
+      const pool2 = createPool('pool2');
+      const wrapper = mountMachinePool(pool1, [pool1, pool2]);
+
+      expect(wrapper.vm.fvExtraRules.uniquePoolName('pool1')).toBeUndefined();
+    });
+
+    it('should return an error message when the pool name is duplicated', () => {
+      const pool1 = createPool('same-name');
+      const pool2 = createPool('same-name');
+      const wrapper = mountMachinePool(pool1, [pool1, pool2]);
+
+      expect(wrapper.vm.fvExtraRules.uniquePoolName('same-name')).toStrictEqual(TRANSLATION_KEY);
+    });
+
+    it('should ignore pools marked for removal', () => {
+      const pool1 = createPool('same-name');
+      const pool2 = createPool('same-name', { remove: true });
+      const wrapper = mountMachinePool(pool1, [pool1, pool2]);
+
+      expect(wrapper.vm.fvExtraRules.uniquePoolName('same-name')).toBeUndefined();
+    });
+
+    it.each([
+      ['Pool1', 'pool1'],
+      ['POOL', 'pool'],
+    ])('should flag names that differ only by case as duplicates (%s vs %s)', (nameA, nameB) => {
+      const pool1 = createPool(nameA);
+      const pool2 = createPool(nameB);
+      const wrapper = mountMachinePool(pool1, [pool1, pool2]);
+
+      expect(wrapper.vm.fvExtraRules.uniquePoolName(nameA)).toStrictEqual(TRANSLATION_KEY);
+    });
+  });
+});

shell/edit/provisioning.cattle.io.cluster/rke2.vue

@@ -2518,14 +2518,14 @@ export default {
           >
             <template
               v-for="(obj, idx) in machinePools"
-              :key="idx"
+              :key="obj.id"
             >
               <Tab
                 v-if="!obj.remove"
                 :key="obj.id"
                 :weight="-1 * idx"
                 :name="obj.id"
-                :label="obj.pool.name || '(Not Named)'"
+                :label="obj.pool.name || t('cluster.machinePool.name.notNamed')"
                 :show-header="false"
                 :error="!machinePoolValidation[obj.id]"
               >

shell/edit/provisioning.cattle.io.cluster/tabs/MachinePool.vue

@@ -106,6 +106,16 @@ export default {
           const max = this.value?.pool?.autoscalingMaxSize || 0;
 
           return max - min >= 0 ? undefined : this.t('cluster.machinePool.autoscaler.validation.isAutoscalerMaxGreaterThanMin');
+        },
+        uniquePoolName: (name) => {
+          if (!name) {
+            return undefined;
+          }
+
+          const otherPools = (this.machinePools || []).filter((p) => !p.remove && p !== this.value);
+          const isDuplicate = otherPools.some((p) => p.pool.name?.toLowerCase() === name.toLowerCase());
+
+          return isDuplicate ? this.t('cluster.machinePool.name.unique') : undefined;
         }
       }
     };
@@ -295,6 +305,7 @@ export default {
           :label="t('cluster.machinePool.name.label')"
           :required="true"
           :disabled="!value.config || !!value.config.id || busy"
+          :require-dirty="false"
           :rules="fvGetAndReportPathRules(MACHINE_POOL_VALIDATION.FIELDS.NAME)"
           data-testid="machine-pool-name-input"
         />

shell/utils/validators/machine-pool.ts

@@ -12,7 +12,7 @@ const RULESETS = [
   },
   {
     path:  FIELDS.NAME,
-    rules: ['required'],
+    rules: ['required', 'uniquePoolName'],
   },
   {
     path:  FIELDS.AUTOSCALER_MIN,