Avoid 'Directory not empty' race when removing dashboard dir

Replace 'sudo rm -rf ~/dashboard' with an atomic mv-then-delete pattern.
On NFS or overlayfs, rm -rf can race against open file handles (e.g. from
Docker mounts or node processes), causing ENOTEMPTY on core-js and similar
deeply nested node_modules directories.

The mv is atomic on the same filesystem, so the clone can proceed
immediately while the old directory is cleaned up in the background.

Author: izaac

cypress/jenkins/Jenkinsfile

@@ -41,7 +41,8 @@ node('harvester-vpn-1') {
               stage('Pre-Clean') {
                 sh """#!/bin/bash
                   set +x
-                  sudo rm -rf "\${HOME}/dashboard" 2>/dev/null || true
+                  mv "\${HOME}/dashboard" "\${HOME}/dashboard.old.\$\$" 2>/dev/null || true
+                  rm -rf "\${HOME}/dashboard.old."* 2>/dev/null &
                   rm -f "\${HOME}/.env" 2>/dev/null || true
                   rm -rf "\${HOME}/.corral" 2>/dev/null || true
                   docker rm -f \$(docker ps -aq --filter ancestor=dashboard-test) 2>/dev/null || true
@@ -103,8 +104,9 @@ node('harvester-vpn-1') {
                   set +x
                   # Remove credentials file
                   rm -f "\${HOME}/.env" || true
-                  # Remove cloned dashboard (may have root-owned files from Docker)
-                  sudo rm -rf "\${HOME}/dashboard" || true
+                  # Remove cloned dashboard (move-then-delete avoids NFS/overlayfs race)
+                  mv "\${HOME}/dashboard" "\${HOME}/dashboard.old.\$\$" 2>/dev/null || true
+                  rm -rf "\${HOME}/dashboard.old."* 2>/dev/null || true
                   # Remove corral config to prevent stale vars leaking between runs
                   rm -rf "\${HOME}/.corral" || true
                   # Remove stale Docker containers and image

cypress/jenkins/run.sh

@@ -53,7 +53,9 @@ build_image() {
 
 	echo "Cloning ${target_branch}$([ "${target_branch}" != "master" ] && echo ', overlaying CI from master')"
 
-	sudo rm -rf "${HOME}"/dashboard
+	# Move-then-delete avoids "Directory not empty" race on NFS/overlayfs
+	mv "${HOME}/dashboard" "${HOME}/dashboard.old.$$" 2>/dev/null || true
+	rm -rf "${HOME}/dashboard.old."* 2>/dev/null &
 	git clone -b "${target_branch}" \
 		"${GITHUB_URL}${DASHBOARD_REPO}" "${HOME}"/dashboard