-
Notifications
You must be signed in to change notification settings - Fork 334
Fix incorrect button sizes introduced by changes to RcButton #16755
Copy link
Copy link
Open
Labels
QA/dev-automationIssues that engineers have written automation around so QA doesn't have look at thisIssues that engineers have written automation around so QA doesn't have look at thisarea/dashboardkind/bugsmall-scope (mixin)A smaller issue that's a good candidate to mixin with other issues in a sprintA smaller issue that's a good candidate to mixin with other issues in a sprintstatus/backport-candidate
Milestone
Metadata
Metadata
Assignees
Labels
QA/dev-automationIssues that engineers have written automation around so QA doesn't have look at thisIssues that engineers have written automation around so QA doesn't have look at thisarea/dashboardkind/bugsmall-scope (mixin)A smaller issue that's a good candidate to mixin with other issues in a sprintA smaller issue that's a good candidate to mixin with other issues in a sprintstatus/backport-candidate
Type
Fields
Give feedbackNo fields configured for issues without a type.
The original call out was that the Show Configuration, Edit and Cancel buttons were the wrong size.
After reviewing this against the design system and detail page designs these are actually correct. However, I did run into some other bugs and visual discrepancies when there was a mix of RcButton and class based buttons on the same page.
Here are the main issues that stood out as breaking visual consistency to me:
Gap is too large:
Bulk action is too small:
Create/Cancel/Save not using RcButton
Wizard buttons not using RcButton
List page Create not using RcButton
This isn't exhaustive but it allows the RcButtons to blend in better with the rest of the app even when the areas aren't using the RcButton.