Skip to content

[Jenkins] - Fix e2e diagnostic tabbable uncaught exeption#17076

Merged
IsaSih merged 6 commits into
rancher:masterfrom
IsaSih:fix-generic-e2e
Apr 7, 2026
Merged

[Jenkins] - Fix e2e diagnostic tabbable uncaught exeption#17076
IsaSih merged 6 commits into
rancher:masterfrom
IsaSih:fix-generic-e2e

Conversation

@IsaSih
Copy link
Copy Markdown
Contributor

@IsaSih IsaSih commented Mar 30, 2026

Summary

Fixes #
(rancher/qa-tasks#2270)

Occurred changes and/or fixed issues

Added tabbable exception to cypress uncaught:exception and added an aftereach hook to cleanup the test environment by deleting the downloaded file. Also, added the qase test ID.

Areas or cases that should be tested

the diagnostics.spec.ts

Areas which could experience regressions

Diagnostics page

Screenshot/Video

Screenshot 2026-03-27 at 15 46 50

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@IsaSih IsaSih added this to the v2.15.0 milestone Mar 30, 2026
@IsaSih IsaSih changed the title Fix generic e2e [Jenkins] - Fix e2e diagnostic tabbable uncaught exeption Mar 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the generic Diagnostics page e2e spec to be more stable in CI by integrating Qase IDs, tolerating known focus-trap-related uncaught exceptions during download modal close, and cleaning up downloaded artifacts between tests.

Changes:

  • Wraps the diagnostics download test with qase(1454, ...) for Qase reporting.
  • Extends uncaught:exception filtering to ignore additional “tabbable” errors associated with the focus-trap modal behavior.
  • Adds an afterEach cleanup step to remove the downloaded diagnostics JSON.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cypress/e2e/tests/pages/generic/diagnostic.spec.ts Outdated
Comment thread cypress/e2e/tests/pages/generic/diagnostic.spec.ts Outdated
Comment thread cypress/e2e/tests/pages/generic/diagnostic.spec.ts Outdated
@yonasberhe23
Copy link
Copy Markdown
Contributor

@IsaSih please apply changes based on copilot's suggestions

Comment thread cypress/e2e/tests/pages/generic/diagnostic.spec.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cypress/e2e/tests/pages/generic/diagnostic.spec.ts Outdated
Comment thread cypress/e2e/tests/pages/generic/diagnostic.spec.ts
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cypress/e2e/tests/pages/generic/diagnostic.spec.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

yonasberhe23
yonasberhe23 previously approved these changes Apr 6, 2026
IsaSih added 6 commits April 7, 2026 07:40
Signed-off-by: Isabela Guimaraes <isabela.guimaraes@suse.com>
Signed-off-by: Isabela Guimaraes <isabela.guimaraes@suse.com>
Signed-off-by: Isabela Guimaraes <isabela.guimaraes@suse.com>
Signed-off-by: Isabela Guimaraes <isabela.guimaraes@suse.com>
Signed-off-by: Isabela Guimaraes <isabela.guimaraes@suse.com>
Signed-off-by: Isabela Guimaraes <isabela.guimaraes@suse.com>
@IsaSih IsaSih merged commit cb77e43 into rancher:master Apr 7, 2026
64 of 65 checks passed
@IsaSih IsaSih self-assigned this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants