Fix delay when navigating to a cluster#17733
Merged
richard-cox merged 2 commits intoMay 21, 2026
Merged
Conversation
9 tasks
Member
Author
|
I re-ran the whole suite of tests 10 times. No single run passed all tests. Many failed on different tests each time I've dived into them all and i don't think any are now related to this PR. The number of same tests sequentially failing is low and i expect are failing in other PRs but pass on the automatic second run Ones of note
From run 10 (re-running failed suites)
|
richard-cox
commented
May 20, 2026
| nameDisplay: 'cluster1', | ||
| id: 'an-id1', | ||
| mgmt: { id: 'an-id1' }, | ||
| isReady: true |
richard-cox
commented
May 20, 2026
|
|
||
| worker.postMessage({ destroyWorker: true }); // we're only passing the boolean here because the key needs to be something truthy to ensure it's passed on the object. | ||
| cleanupTasks.push(waitFor(() => !this.$workers[getters.storeName], 'Worker is destroyed')); | ||
| cleanupTasks.push(waitFor(() => !this.$workers?.[storeName], 'Worker to be destroyed', 30000, 10, true)); |
Member
Author
There was a problem hiding this comment.
i've made the check
- safer given $workers and getter might get nuked
- limited to 30 seconds, it really shouldn't take that long
- check every 10ms
- log activity (which will help in future)
9 tasks
nwmac
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #17634
Occurred changes and/or fixed issues
loadCluster-->await dispatch('cluster/unsubscribe');-->cleanupTasks.push(waitFor(() => !this.$workers[getters.storeName], 'Worker is destroyed'));loadClusterand feature flagTechnical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Checklist
Admin,Standard UserandUser Base