Migrate Azure AD auth provider to the `useFormValidation` composable

[rak-phillip]

shell/edit/auth/azuread.vue already has field-level validation using the form validation mixin. Migrate this form to the useFormValidation composable.

Recommended approach

Replace the form validation mixin with useFormValidation in setup(). Most of the current rule sets migrate directly because formRulesGenerator already provides required and url rules. Extra rules can expressed as functions in the extraRules argument.

Acceptance criteria

• The form validation mixin is removed from the component
• useFormValidation is used in setup() with the existing rule sets
• Custom validators (applicationSecretRequired, endSessionEndpointRequiredAndValid) are expressed as extraRules
• isFormValid from the composable drives :validation-passed on CruResource
• Inline error tooltips continue to appear on blur for all validated fields
• The Enable button remains disabled while required fields are empty or contain invalid URLs
• Existing unit tests in shell/edit/auth/__tests__/azuread.test.ts continue to pass

[github-actions]

🎯 Agentic Issue Triage

This is a refactoring task to migrate the Azure AD auth provider form (shell/edit/auth/azuread.vue) from the legacy form validation mixin to the useFormValidation composable. The issue has clear acceptance criteria and existing unit tests must continue to pass.

📋 Summary & Context

Type: Refactor / Tech debt
Component: shell/edit/auth/azuread.vue
Milestone: v2.15.0
Complexity: Medium — the form already has field-level validation; this is a migration, not a ground-up implementation.

This is part of a broader effort to move forms from the older mixin-based validation pattern to the useFormValidation composable (see also #17777 for SAML, #17778 for LDAP, and #17354 for the umbrella tracking issue).

🔍 Key Files

File	Purpose
shell/edit/auth/azuread.vue	Target component to migrate
shell/edit/auth/__tests__/azuread.test.ts	Existing unit tests that must remain passing
shell/composables/useFormValidation.ts	Target composable
shell/mixins/formValidation.js	Mixin to be removed

🛠️ Implementation Approach

1. Remove the formValidation mixin import and its usage from azuread.vue.
2. Import useFormValidation and call it in setup() with the existing rule sets.
3. Map existing rules — formRulesGenerator already provides required and url validators so most rules migrate directly.
4. Express custom validators (applicationSecretRequired, endSessionEndpointRequiredAndValid) as extraRules functions in the composable arguments.
5. Wire isFormValid from the composable to :validation-passed on <CruResource>.
6. Verify blur behavior: inline error tooltips must still appear on blur for all validated fields.
7. Run yarn test:ci shell/edit/auth/__tests__/azuread.test.ts to confirm existing tests pass.
8. Run yarn lint to ensure code style compliance.

✅ Checklist

• Remove formValidation mixin from azuread.vue
• Add useFormValidation call in setup() with all existing rule sets
• Implement applicationSecretRequired as an extraRule
• Implement endSessionEndpointRequiredAndValid as an extraRule
• Bind isFormValid → :validation-passed on CruResource
• Manually verify inline error tooltips appear on blur for each validated field
• Manually verify the Enable button is disabled while required fields are empty or contain invalid URLs
• All existing unit tests in azuread.test.ts pass
• Lint passes

🔗 Related Issues & Resources

• Umbrella tracking issue: Find a way to migrate existing forms with validation to vee-validate #17354 — Migration plan for all forms using the old mixin
• Similar completed/open migrations: Validate the saml auth provider form with vee-validate #17777 (SAML), Validate LDAP auth provider form using vee-validate #17778 (LDAP)
• useFormValidation composable — located at shell/composables/useFormValidation.ts; review its API for extraRules usage before starting
• Existing Azure AD tests — shell/edit/auth/__tests__/azuread.test.ts provide a safety net; run them frequently during the migration

Generated by Agentic Triage for issue #17791 · ● 240.2K · ◷

[github-actions]

🤖 Issue grooming analysis

This issue is well-groomed and ready for triage. Here is a summary of how it meets all four primary criteria:

✅ Clear Problem Statement
The title and description clearly identify the task: migrate shell/edit/auth/azuread.vue from the form validation mixin to the useFormValidation composable. The context (the file already uses field-level validation via a mixin) and motivation (standardise on the composable) are both clear.

✅ Acceptance Criteria
A concrete, testable checklist is provided:

• Form validation mixin removed from the component
• useFormValidation used in setup() with existing rule sets
• Custom validators (applicationSecretRequired, endSessionEndpointRequiredAndValid) expressed as extraRules
• isFormValid drives :validation-passed on CruResource
• Inline error tooltips continue to appear on blur
• Enable button remains disabled while required fields are empty or invalid
• Existing unit tests in shell/edit/auth/__tests__/azuread.test.ts continue to pass

✅ Technical Details
The specific file (shell/edit/auth/azuread.vue), composable (useFormValidation), and migration approach are all clearly described. The formRulesGenerator mapping and the extraRules pattern are both called out explicitly.

✅ Reproducibility / User Story
This is a refactoring task with a clear user story: the form should behave identically after migration, with the composable as the sole validation mechanism. No reproduction steps are needed for a refactor.

This analysis was generated automatically based on the repository's grooming checklist.

Generated by Daily Issue Grooming · ● 972.7K · ◷