Set Ready condition to Unknown for offline clusters

This better reflects what is then known about workloads running in such
clusters than `False`.

Author: weyfonk

internal/cmd/agent/deployer/monitor/condition.go

@@ -44,6 +44,14 @@ func (c Cond) IsFalse(obj interface{}) bool {
 	return getStatus(obj, string(c)) == "False"
 }
 
+func (c Cond) Unknown(obj interface{}) {
+	setStatus(obj, string(c), "Unknown")
+}
+
+func (c Cond) IsUnknown(obj interface{}) bool {
+	return getStatus(obj, string(c)) == "Unknown"
+}
+
 func (c Cond) Reason(obj interface{}, reason string) {
 	cond := findOrCreateCond(obj, string(c))
 	getFieldValue(cond, "Reason").SetString(reason)

internal/cmd/controller/clustermonitor/monitor.go

@@ -115,12 +115,10 @@ func UpdateOfflineBundleDeployments(ctx context.Context, c client.Client, thresh
 				for _, cond := range bd.Status.Conditions {
 					switch cond.Type {
 					case "Ready":
-						// FIXME: avoid relying on agent pkg for this?
 						mc := monitor.Cond(v1alpha1.BundleDeploymentConditionReady)
 						mc.SetError(&t.Status, "Cluster offline", errors.New(offlineMsg))
 						mc.Unknown(&t.Status)
 						// XXX: do we want to set Deployed and Installed conditions as well?
-						// XXX: should we set conditions to `Unknown`?
 					case "Monitored":
 						mc := monitor.Cond(v1alpha1.BundleDeploymentConditionMonitored)
 						mc.SetError(&t.Status, "Cluster offline", errors.New(offlineMsg))

internal/cmd/controller/clustermonitor/monitor_test.go

@@ -42,7 +42,7 @@ func (m BDStatusMatcher) Matches(x interface{}) bool {
 		if cond.Type == "Ready" {
 			foundReady = true
 
-			if cond.Status != "False" ||
+			if cond.Status != "Unknown" ||
 				!strings.Contains(cond.Reason, "offline") ||
 				!strings.Contains(cond.Message, "offline") {
 				return false