Address Copilot's comments

Author: weyfonk

e2e/multi-cluster/offline_cluster_test.go

@@ -155,9 +155,9 @@ func checkReadyCondition(g Gomega, out, msg, status string) {
 	g.Expect(err).ToNot(HaveOccurred())
 
 	var readyCond *genericcondition.GenericCondition
-	for _, c := range conds {
+	for i, c := range conds {
 		if c.Type == "Ready" {
-			readyCond = &c
+			readyCond = &conds[i]
 		}
 	}
 

internal/cmd/controller/clustermonitor/monitor.go

@@ -110,9 +110,8 @@ func UpdateOfflineBundleDeployments(ctx context.Context, c client.Client, thresh
 				if err := c.Get(ctx, nsn, t); err != nil {
 					return err
 				}
-				t.Status = bd.Status
 
-				orig := bd.DeepCopy()
+				orig := t.DeepCopy()
 
 				// Any information about resources living in an offline cluster is likely to be
 				// outdated.
@@ -129,7 +128,12 @@ func UpdateOfflineBundleDeployments(ctx context.Context, c client.Client, thresh
 
 				statusPatch := client.MergeFrom(orig)
 
-				if patchData, err := statusPatch.Data(t); err != nil || string(patchData) != "{}" {
+				patchData, err := statusPatch.Data(t)
+				if err != nil {
+					return err
+				}
+
+				if string(patchData) != "{}" {
 					return c.Status().Patch(ctx, t, statusPatch)
 				}
 

internal/cmd/controller/clustermonitor/monitor_test.go

@@ -457,7 +457,7 @@ func Test_Run(t *testing.T) {
 							b *v1alpha1.BundleDeployment, //nolint: staticcheck
 							opts ...client.GetOption,
 						) error {
-							b = &bd //nolint: ineffassign,staticcheck // the value is used by the implementation, not directly by the tests.
+							*b = bd //nolint: ineffassign,staticcheck // the value is used by the implementation, not directly by the tests.
 
 							return nil
 						},