Add comment to stageAllTargets

Author: p-se

internal/cmd/cli/target.go

@@ -177,6 +177,11 @@ func (t *Target) Run(cmd *cobra.Command, args []string) error {
 // stageAllTargets overrides maxNew to the total number of matched targets so
 // that UpdatePartitions stages a deployment for every target, not just the
 // first target.DefaultMaxNew.
+//
+// NOTE: mutating bundle.Spec.RolloutStrategy is visible to UpdatePartitions
+// because target.Manager.Targets() stores the same bundle pointer in every
+// target's Bundle field, and UpdatePartitions reads MaxNew from
+// targets[0].Bundle.Spec.RolloutStrategy.
 func stageAllTargets(bundle *v1alpha1.Bundle, matchedTargets []*target.Target) error {
 	count := len(matchedTargets)
 	if bundle.Spec.RolloutStrategy == nil {