Fix event recorder interface migration (#4896)

* Fix event recorder interface migration

The migration from `controller-runtime`'s `record.EventRecorder` to
`events.EventRecorder` seems to have changed the type of events
generated, which led to permissions errors when recording events.

This commit updates Fleet's gitOps RBAC to take that new event type into
account.

* Add regression end-to-end test for event generation

Single-cluster end-to-end tests for GitRepo deployments now validate
that `GotNewCommit` events are generated, which should help catch future
event recording-related issues.

Author: weyfonk

charts/fleet/templates/rbac_gitjob.yaml

@@ -61,7 +61,7 @@ rules:
       - watch
       - update
   - apiGroups:
-      - ""
+      - "events.k8s.io"
     resources:
       - 'events'
     verbs:

e2e/single-cluster/gitrepo_test.go

@@ -152,6 +152,12 @@ var _ = Describe("Monitoring Git repos via HTTP for change", Label("infra-setup"
 				out, _ := k.Namespace(targetNamespace).Get("deployments")
 				return out
 			}, testenv.MediumTimeout, testenv.ShortTimeout).Should(ContainSubstring("newsleep"))
+
+			By("checking that events are generated")
+			Eventually(func() string {
+				out, _ := k.Get("events", "--field-selector=reason=GotNewCommit")
+				return out
+			}).Should(ContainSubstring(commit))
 		})
 	})