test: fix webhook test race condition

The webhook test was creating the GitRepo resource after pushing content,
which caused a race condition. The git push would trigger the post-receive
webhook, but the GitRepo resource didn't exist yet, so the webhook was
ignored. With polling disabled (24h), the GitRepo never synced.

Fixed by creating the GitRepo resource first, then pushing content. This
ensures the webhook can find and update the GitRepo when triggered.

This also speeds up the test significantly (~14s vs ~21s) since the webhook
triggers immediately instead of waiting for timeout-based retries.

Author: thardeck

e2e/single-cluster/gitrepo_test.go

@@ -269,10 +269,8 @@ var _ = Describe("Monitoring Git repos via HTTP for change", Label("infra-setup"
 				return err
 			}).ShouldNot(HaveOccurred(), out)
 
-			// Clone previously created repo
-			clone, err = gh.Create(clonedir, testenv.AssetPath("gitrepo/sleeper-chart"), "examples")
-			Expect(err).ToNot(HaveOccurred())
-
+			// Create the GitRepo resource first, before pushing content
+			// This ensures the webhook will find the GitRepo when the push triggers it
 			err = testenv.ApplyTemplate(k, testenv.AssetPath("gitrepo/gitrepo.yaml"), struct {
 				Name            string
 				Repo            string
@@ -287,6 +285,10 @@ var _ = Describe("Monitoring Git repos via HTTP for change", Label("infra-setup"
 				targetNamespace, // to avoid conflicts with other tests
 			})
 			Expect(err).ToNot(HaveOccurred())
+
+			// Now push content, which will trigger the webhook
+			clone, err = gh.Create(clonedir, testenv.AssetPath("gitrepo/sleeper-chart"), "examples")
+			Expect(err).ToNot(HaveOccurred())
 		})
 
 		It("updates the deployment", func() {