Skip to content

[SURE-10528] Allow more than one targetCustomization to be applied #3512

@jstanley1730

Description

@jstanley1730

Is your feature request related to a problem?

We are running into an issue where we need to apply multiple targetCustomizations. The current implementation applies the first targetCustomization in your list that matches. We have targetCustomizations for all "edge" clusters vs "enterprise" clusters. We also need to allow for additional customizations users may require to override values via configMap or secret if a given label is specified. In many cases both need applied.

Example

name: istio-cni
defaultNamespace: kube-system
helm:
  releaseName: istio-cni
  repo: https://istio-release.storage.googleapis.com/charts
  chart: cni
  valuesFiles:
    - values.yaml

targetCustomizations:
  - name: istio-cni-values-override-configmap
    helm: 
      valuesFrom:
        - configMapKeyRef::
            name: istio-cni-values-override
            namespace: istio-system
            key: istio-cni-values.yaml    
    clusterSelector:
      matchLabels:
          istio-cni-values-override-configmap: 'true'
  - name: edge-values
    clusterSelector:
      matchLabels:
        edge: "true"
    helm:
      valuesFiles:
        - values/edge.yaml

Solution you'd like

Would like the ability for all matching target customizations to be applied.

Alternatives you've considered

We have combined labels for the matchSelection but when there is a longer list of targetCustomizations this gets unmaintainable and repetitive.

Anything else?

No response

Metadata

Metadata

Assignees

No fields configured for Feature.

Projects

Status

👀 In review

Relationships

None yet

Development

No branches or pull requests

Issue actions