Automatically delete `fleet-agent-my-cluster` Bundle on Cluster deletion

[anmazzotti]

Is your feature request related to a problem?

When registering a new Cluster, Fleet creates a Bundle named fleet-agent-* to install the agent downstream.

However, when the Cluster is deleted, this Bundle is not deleted by anything and will persist on your management cluster forever.
The Bundle is also owned by the Namespace (where the Cluster is created). This is incorrect, as it prevents logically from deploying multiple Clusters in the same Namespace.

Solution you'd like

The auto-generated fleet-agent Bundle should be owned by the Cluster and deleted automatically when the Cluster is deleted.

Alternatives you've considered

No response

Anything else?

No response

[weyfonk]

Probably fixed through #3985 🤔 ; could you confirm?

[anmazzotti]

@weyfonk I just tested this and nope, that didn't fix it. The change you linked deletes the managed fleet namespace.
The fleet-agent-<clustername> Bundle lives in the same namespace as the fleet.cattle.io.Cluster, in my case default, and no that namespace is not managed and should not be deleted.

The solution here is probably to make the Bundle owned by the Cluster? So that it will be deleted on cascade? I'm not sure how it is supposed to be handled, but it should be cleaned up if the Fleet Cluster is deleted. Is there any reason the Bundle to install the fleet-agent still exists for a deleted Cluster?

[weyfonk]

Is there any reason the Bundle to install the fleet-agent still exists for a deleted Cluster?

There shouldn't be, that is just wasteful. Thanks for raising this :)

Either the agent management controllers should take care of that, or the cluster controller.