Skip to content

Ensure conversion of empty characters to %20 on backend when passing gitrepo URL with empty spaces #4623

@mmartin24

Description

@mmartin24

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Follow-up of 4058.


Passing an empty URL via Yaml with an Azure webhook will not work.

Image

Expected Behavior

Ensure Fleet backend automatically translates empty spaces passed to a gitrepo URl into %20 to ensure webhooks work also in this circumstance.

Note from @0xavi0 : consider use of url.PathEscape()

Steps To Reproduce

Prepare azure webhook. A guide can be found here.
Pass gitrepo with empty url in the yaml. For example https://fleetqa@dev.azure.com/fleetqateam/_git/fleet qa with spaces
Observe how currently is not possible

Environment

- Architecture: amd64
- Fleet Version: 0.13.6 onwards
- Cluster:
  - Provider:k3s
  - Options:
  - Kubernetes Version: 1.33.2+k3s1

Logs

Anything else?

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions