Skip to content

Feature Request: Add early validation for incorrect regexp malformation when deploying jobs #4663

@mmartin24

Description

@mmartin24

Is your feature request related to a problem?

Follow up on #748
Related comment: #748 (comment)


Issue:

When passing an incorrect Regexp (ie: name: ttl-test-["·Ewdfsdfsad0?-job) an error is trigered at agent level pod:

k logs -n cattle-fleet-local-system pods/fleet-agent-7f944bbd75-bvj4d | tail

Output:

{"level":"error","ts":"2026-02-17T13:52:53Z","logger":"bundledeployment.update-status","msg":"Cannot compile bundle diff ignore regex, will discard it","controller":"bundledeployment","controllerGroup":"fleet.cattle.io","controllerKind":"BundleDeployment","BundleDeployment":{"name":"test-ttl-748-ttl-jobs-ttl-test","namespace":"cluster-fleet-local-local-1a3d67d0a899"},"namespace":"cluster-fleet-local-local-1a3d67d0a899","name":"test-ttl-748-ttl-jobs-ttl-test","reconcileID":"7b45a0fa-ce6f-488c-9710-e930b4af3eda","namespace":"default","name pattern":"ttl-test-[\"·Ewdfsdfsad0?-job","gvk":"batch/v1, Kind=Job","error":"error parsing regexp: missing closing ]: `[\"·Ewdfsdfsad0?-job`","stacktrace":"github.com/rancher/fleet/internal/cmd/agent/deployer/desiredset.Diff\n\t/home/runner/_work/fleet/fleet/internal/cmd/agent/deployer/desiredset/diff.go:59\ngithub.com/rancher/fleet/internal/cmd/agent/deployer/monitor.(*Monitor).updateFromPreviousDeployment\n\t/home/runner/_work/fleet/fleet/internal/cmd/agent/deployer/monitor/updatestatus.go:186\ngithub.com/rancher/fleet/internal/cmd/agent/deployer/monitor.(*Monitor).UpdateStatus\n\t/home/runner/_work/fleet/fleet/internal/cmd/agent/deployer/monitor/updatestatus.go:97\ngithub.com/rancher/fleet/internal/cmd/agent/controller.(*BundleDeploymentReconciler).Reconcile\n\t/home/runner/_work/fleet/fleet/internal/cmd/agent/controller/bundledeployment_controller.go:209\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.4/pkg/internal/controller/controller.go:216\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.4/pkg/internal/controller/controller.go:461\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.4/pkg/internal/controller/controller.go:421\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func1.1\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.22.4/pkg/internal/controller/controller.go:296"}
Image

Request

The idea is to implement an early stage detection of this issue that helps to be displayed in the in a similar way it was done for this other issue #4582

Solution you'd like

No response

Alternatives you've considered

No response

Anything else?

No response

Metadata

Metadata

Assignees

No one assigned
    No fields configured for Feature.

    Projects

    Status

    📋 Backlog

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions