Skip to content

[backport v2.13] Certain errors not being shown in gitjob conditions #5184

@rancherbot

Description

@rancherbot

This is a backport issue for #3973, automatically created via GitHub Actions workflow initiated by @0xavi0

Original issue body:

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Discovered while testing #3880

Image

A not found helm secret name is not displayed in the UI, but they are found in the events of the gitrepo. It seems certain errors are not shown on gitjob conditions.

Expected Behavior

The UI should reflect this error because we can correctly process it.

Steps To Reproduce

Follow as reference steps defined in the reference ticket.

I managed to reproduce like this:

apiVersion: fleet.cattle.io/v1alpha1
kind: GitRepo
metadata:
  name: sample
  namespace: fleet-local
spec:
  repo: "https://github.com/mmartin24/test-fleet/"
  branch: master
  paths:
  - "3888-docker"
  helmSecretName: oci-helm-secret
  • Observe how the repo cannot be deployed an an error appears (expected)
  • Delete the secret
  • Force update
  • Observe the UI does not display anything but in the gitrepo events we show the reason: failed to look up helmSecretName, error: Secret "oci-helm-secret" not found

Environment

- Architecture:
- Fleet Version:
- Cluster:
  - Provider:
  - Options:
  - Kubernetes Version:

Logs

Anything else?

No response

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

Status

🆕 New

Relationships

None yet

Development

No branches or pull requests

Issue actions