webhook: use regexp.QuoteMeta for hostname and path#5153
Open
p-se wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens webhook GitRepo URL matching by escaping user-controlled hostname/path segments before building the matching regexp, preventing regexp metacharacters in webhook payload URLs from matching unintended GitRepos.
Changes:
- Escape webhook payload URL hostname and path with
regexp.QuoteMeta()when constructing the repo-matching regexp. - Add a regression test ensuring wildcard-like webhook URLs (e.g.
.*) do not match unrelated GitRepo URLs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/webhook/webhook.go | Escapes hostname/path components before regexp compilation to avoid regexp metacharacter injection in URL matching. |
| pkg/webhook/webhook_test.go | Adds a regression test covering “wildcard” hostname/path inputs in webhook payload repo URLs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if err != nil { | ||
| t.Fatalf("failed to create request: %v", err) | ||
| } | ||
| req.Header.Set("X-GitHub-Event", "push") |
Comment on lines
+972
to
+981
| rr := httptest.NewRecorder() | ||
| w.ServeHTTP(rr, req) | ||
|
|
||
| updated := &v1alpha1.GitRepo{} | ||
| if err := fakeClient.Get(context.TODO(), types.NamespacedName{Name: gitRepo.Name, Namespace: gitRepo.Namespace}, updated); err != nil { | ||
| t.Fatalf("failed to get gitrepo: %v", err) | ||
| } | ||
| if updated.Status.WebhookCommit != "" { | ||
| t.Errorf("expected WebhookCommit to remain empty (no match), but got %q", updated.Status.WebhookCommit) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Information
Checklist