fleet-cli: add missing flag wiring for apply, cleanup subcommands#5171
Open
apoorvajagtap wants to merge 1 commit into
Open
fleet-cli: add missing flag wiring for apply, cleanup subcommands#5171apoorvajagtap wants to merge 1 commit into
apoorvajagtap wants to merge 1 commit into
Conversation
apoorvajagtap
force-pushed
the
11634-kubeconfig
branch
from
6a2d787 to
eb13b82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refers to #5170
This commit adds
AddGoFlagSetto subcommands that were missing it:With this controller-runtime's
--kubeconfigand zap's--zap-*flags (for clusterregistration & gitjob ) are correctly bridged from the stdlib flag set into cobra's pflag set.Additional Information
Checklist