#1279 - [BUG] RKE1 vSphere external (out-of-tree) cloud provider description, has a docs link which leads to 404 Not Found #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iption, has a docs link which leads to 404 Not Found
martyav
requested review from
btat,
LucasSaintarbor and
sunilarjun
as code owners
|
This doesn't fix #1279. The URL of the problematic link is https://rancher.com/docs/rancher/v2.8/en/cluster-provisioning/rke-clusters/cloud-providers/vsphere/out-of-tree (different domain) so the request never reaches our Docusaurus site for it to redirect. This needs to be fixed on https://github.com/rancher/docs/, but I haven't made the fix there yet because of an ongoing caching issue that's blocking updates from going live. General feedback on redirects:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1279
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.
Description
A link in the Rancher UI points to https://rancher.com/docs/rancher/v2.8/en/cluster-provisioning/rke-clusters/cloud-providers/vsphere/out-of-tree, which returns a
404. The correct path is https://ranchermanager.docs.rancher.com/how-to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-cloud-providers/configure-out-of-tree-vsphere. Only v2.8 is reported as affected.I added a redirect, patterned after the redirects on lines 2398 to 2406 in the Docusuarus config file. Since all those redirects also point to files in the now-removed path
/v2.8/cluster-provisioning/rke-clusters, I wonder if this broken redirect is related to the same issue (dashboard#9970)?Comments