-
Notifications
You must be signed in to change notification settings - Fork 119
Open
Description
If a deadline is set, r.cond.Broadcast() is called without obtaining a lock and that opens up the posibility of a race where the broadcast could be called first, and r.cond.Wait() would miss it, potentially leading to a blocked goroutine.
Line 115 in eac401e
| t = time.AfterFunc(r.deadline.Sub(now), func() { r.cond.Broadcast() }) |
This is a follow up from the following PR review discussion: #68 (comment). So far, it was not observed in Rancher user installations
Reactions are currently unavailable