Follow the comments

Author: ericpromislow

pkg/sqlcache/integration_test.go

@@ -540,6 +540,7 @@ func waitForObjectsBySchema(ctx context.Context, proxyStore *sqlproxy.Store, sch
 	})
 }
 
+// Do not call this if there are no projects -- the function will run until it times out.
 func waitForProjectsDisplayName(ctx context.Context, proxyStore *sqlproxy.Store, schema *types.APISchema) error {
 	return wait.PollUntilContextCancel(ctx, time.Second*10, true, func(ctx context.Context) (done bool, err error) {
 		req, err := http.NewRequest("GET", "http://localhost:8080", nil)
@@ -553,8 +554,9 @@ func waitForProjectsDisplayName(ctx context.Context, proxyStore *sqlproxy.Store,
 		list, total, _, err := proxyStore.ListByPartitions(apiOp, schema, partitions)
 		if err != nil || total == 0 {
 			// note that we don't return the error since that would stop the polling
-			return false, err
+			return false, nil
 		}
+		// Moving on, if there are errors return them
 		for _, item := range list.Items {
 			displayName, ok, err := unstructured.NestedFieldNoCopy(item.Object, "spec", "displayName")
 			if !ok || displayName == "" || err != nil {