Fix mutex not released on error (#891)

aruiz14 · web-flow · commit 9cccbed61a9a · 2025-11-07T14:37:01.000-05:00
Follow up of #873
diff --git a/pkg/sqlcache/informer/factory/informer_factory.go b/pkg/sqlcache/informer/factory/informer_factory.go
@@ -192,6 +192,8 @@ func (f *CacheFactory) cacheForLocked(ctx context.Context, gi *guardedInformer,
 		shouldEncrypt := f.encryptAll || encryptResourceAlways
 		i, err := f.newInformer(f.ctx, client, fields, externalUpdateInfo, selfUpdateInfo, transform, gvk, f.dbClient, shouldEncrypt, namespaced, watchable, f.gcInterval, f.gcKeepCount)
 		if err != nil {
+			gi.informerMutex.Unlock()
+			log.Errorf("Error creating informer for %v: %v", gvk, err)
 			return nil, err
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -192,6 +192,8 @@ func (f CacheFactory) cacheForLocked(ctx context.Context, gi guardedInformer,`
`192`	`192`	`shouldEncrypt := f.encryptAll \|\| encryptResourceAlways`
`193`	`193`	`i, err := f.newInformer(f.ctx, client, fields, externalUpdateInfo, selfUpdateInfo, transform, gvk, f.dbClient, shouldEncrypt, namespaced, watchable, f.gcInterval, f.gcKeepCount)`
`194`	`194`	`if err != nil {`
	`195`	`+ gi.informerMutex.Unlock()`
	`196`	`+ log.Errorf("Error creating informer for %v: %v", gvk, err)`
`195`	`197`	`return nil, err`
`196`	`198`	`}`
`197`	`199`