fix: use string instead of *string for PrioClassName

Author: maltelehmann

pkg/apis/upgrade.cattle.io/v1/types.go

@@ -83,7 +83,7 @@ type PlanSpec struct {
 	// Time after a Job for one Node is complete before a new Job will be created for the next Node.
 	PostCompleteDelay *metav1.Duration `json:"postCompleteDelay,omitempty"`
 	// Priority Class Name of Job, if specified.
-	PriorityClassName *string `json:"priorityClassName,omitempty"`
+	PriorityClassName string `json:"priorityClassName,omitempty"`
 }
 
 // PlanStatus represents the resulting state from processing Plan events.

pkg/apis/upgrade.cattle.io/v1/zz_generated_deepcopy.go

@@ -195,6 +195,7 @@ func New(plan *upgradeapiv1.Plan, node *corev1.Node, controllerName string) *bat
 					HostPID:            true,
 					HostNetwork:        true,
 					DNSPolicy:          corev1.DNSClusterFirstWithHostNet,
+					PriorityClassName:  plan.Spec.PriorityClassName,
 					ServiceAccountName: plan.Spec.ServiceAccountName,
 					Affinity: &corev1.Affinity{
 						NodeAffinity: &corev1.NodeAffinity{
@@ -282,10 +283,6 @@ func New(plan *upgradeapiv1.Plan, node *corev1.Node, controllerName string) *bat
 
 	podTemplate := &job.Spec.Template
 
-	// setup priority class
-	if prioClassName := plan.Spec.PriorityClassName; prioClassName != nil {
-		podTemplate.Spec.PriorityClassName = *prioClassName
-	}
 	// setup secrets volumes
 	for _, secret := range plan.Spec.Secrets {
 		podTemplate.Spec.Volumes = append(podTemplate.Spec.Volumes, corev1.Volume{