Changes from code review.

Author: Mauren Berti

rancher2/schema_app_v2.go

@@ -91,10 +91,12 @@ func appV2Fields() map[string]*schema.Schema {
 			DiffSuppressFunc: suppressAppDiff,
 		},
 		"deployment_values": {
-			Type:        schema.TypeString,
-			Computed:    true,
-			Sensitive:   false,
-			Description: "App v2 computed values YAML file",
+			Type:      schema.TypeString,
+			Computed:  true,
+			Sensitive: false,
+			Description: "Values YAML file including computed values. This field prevents incorrect discrepancies from " +
+				"showing in the terraform plan output when files change but values stay the same, due to additional " +
+				"computed values included by the provider itself.",
 		},
 		"cleanup_on_fail": {
 			Type:        schema.TypeBool,
@@ -142,7 +144,7 @@ func validateAppSchema(val interface{}, key string) (warns []string, errs []erro
 	}
 	_, err := ghodssyamlToMapInterface(v)
 	if err != nil {
-		errs = append(errs, fmt.Errorf("%q must be in yaml format, error: %v", key, err))
+		errs = append(errs, fmt.Errorf("[ERROR] %q must be in YAML format, error: %v", key, err))
 		return
 	}
 	return

rancher2/structure_app_v2.go

@@ -71,7 +71,7 @@ func expandChartInstallV2(in *schema.ResourceData, chartInfo *types.ChartInfo) (
 	globalInfo := generateGlobalInfoMap(in)
 	valuesData := v3.MapStringInterface{}
 	if v, ok := in.Get("values").(string); ok {
-		values, err := unmarshallValuesContent(v)
+		values, err := unmarshalValuesContent(v)
 		if err != nil {
 			return "", nil, err
 		}
@@ -201,7 +201,7 @@ func expandChartUpgradeV2(in *schema.ResourceData, chartInfo *types.ChartInfo) (
 	globalInfo := generateGlobalInfoMap(in)
 	valuesData := v3.MapStringInterface{}
 	if v, ok := in.Get("values").(string); ok {
-		values, err := unmarshallValuesContent(v)
+		values, err := unmarshalValuesContent(v)
 		if err != nil {
 			return "", nil, err
 		}
@@ -257,10 +257,10 @@ func expandChartUpgradeV2(in *schema.ResourceData, chartInfo *types.ChartInfo) (
 	return namespace, out, nil
 }
 
-func unmarshallValuesContent(v string) (map[string]interface{}, error) {
+func unmarshalValuesContent(v string) (map[string]interface{}, error) {
 	values, err := ghodssyamlToMapInterface(v)
 	if err != nil {
-		return nil, fmt.Errorf("failed to unmarshal chart install values yaml: %#v", err)
+		return nil, fmt.Errorf("[ERROR] failed to unmarshal chart install values YAML: %#v", err)
 	}
 	if values == nil {
 		values = map[string]interface{}{}