Created pit.crew.style.agent agent and updated pit.crew.schema#713
Open
lscalabrini01 wants to merge 6 commits into
Open
Created pit.crew.style.agent agent and updated pit.crew.schema#713lscalabrini01 wants to merge 6 commits into
lscalabrini01 wants to merge 6 commits into
Conversation
lscalabrini01
requested review from
Copilot,
floatingman,
hamistao and
slickwarren
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s GitHub Copilot CLI custom agents documentation and agent definitions by adding a new code-style enforcement agent and expanding/refining the PIT schema generator agent guidance.
Changes:
- Added a new
pit.crew.code.styleagent definition for enforcing Go test code style conventions. - Expanded
pit.crew.schemaagent instructions (rules + broader list of referenced test/schema locations). - Updated
.github/agents/README.mdto document the new code-style agent and how to invoke it.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/agents/README.md |
Documents the new code-style agent in the custom agents list. |
.github/agents/pit.crew.schema.agent.md |
Refines PIT schema agent front matter and adds explicit schema-generation rules + more referenced suites. |
.github/agents/pit.crew.code.style.agent.md |
Introduces a new agent file containing code-style checklist and reference test files. |
Comments suppressed due to low confidence (1)
.github/agents/pit.crew.code.style.agent.md:90
- The linter checklist contradicts the earlier logging guidance: it says not to use
t.Log()for logging, but later suggests using “the testing package” as an alternative tofmt.Print*. Pick a single standard to avoid sending mixed guidance to agent users.
### Linter compliance
* No `time.Sleep` calls — use appropriate polls and watches instead.
* No `fmt.Print*` calls — use `logrus` or the `testing` package.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ts into qa-issue_pitcrew-agent
lscalabrini01
force-pushed
the
qa-issue_pitcrew-agent
branch
from
006ce1a to
7a09611
Compare
hamistao
approved these changes
Jun 9, 2026
hamistao
left a comment
hamistao
left a comment
Contributor
There was a problem hiding this comment.
Looks good but I included some suggestions
| ## Checklist | ||
|
|
||
| ### File and package structure | ||
| * Helper functions specific to a test package must live in a separate file that does **not** end in `_test.go`. |
Contributor
There was a problem hiding this comment.
Maybe include some direction on where these functions should live, or give an example
Comment on lines
+52
to
+53
| ### Naming conventions | ||
| ### Naming conventions |
| * Automatic cleanup registration (via `session.Cleanup()`) is required. | ||
|
|
||
| ### Helper functions | ||
| * Default to returning an `error` instead of accepting a `*testing.T` parameter. |
Contributor
There was a problem hiding this comment.
We can point out some exceptions here perhaps. Like when additional logging should be included as part of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the repository’s GitHub Copilot CLI custom agents documentation and agent definitions by adding a new code-style enforcement agent and expanding/refining the PIT schema generator agent guidance.
Changes: