Skip to content

Commit 6c82a10

Browse files
committed
Merge pull request #106 from vincent99/master
Show managed containers grey with no actions
2 parents da9c715 + 0ef312d commit 6c82a10

12 files changed

Lines changed: 27 additions & 48 deletions

File tree

app/pods/components/container-widget/component.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import HoverActions from 'ui/mixins/hover-actions';
55
export default Ember.Component.extend(HoverActions, {
66
model: null,
77
classNames: ['instance','resource-action-hover'],
8+
classNameBindings: ['model.isManaged:managed'],
89

910
click: function() {
1011
// For touch devices, show actions on a click anywhere in the component

app/pods/components/container-widget/template.hbs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
{{resource-actions-menu model=model choices=model.availableActions}}
1+
{{#unless model.isManaged}}
2+
{{resource-actions-menu model=model choices=model.availableActions}}
3+
{{/unless}}
24

35
<div class="instance-name">
46
<i {{bind-attr class="model.stateIcon model.stateColor" tooltip=model.displayState}}></i>

app/pods/container/controller.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ var ContainerController = Cattle.TransitioningResourceController.extend({
9494
return ['removed','removing','purging','purged'].indexOf(this.get('state')) === -1;
9595
}.property('state'),
9696

97+
isManaged: Ember.computed.notEmpty('systemContainer'),
98+
9799
primaryHost: Ember.computed.alias('hosts.firstObject'),
98100
});
99101

app/pods/container/template.hbs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717
{{transitioningMessage}}
1818
</div>
1919
<div class="instance-actions">
20-
{{resource-actions model=this choices=availableActions}}
20+
{{#unless isManaged}}
21+
{{resource-actions model=this choices=availableActions}}
22+
{{/unless}}
2123
</div>
2224
</div>
2325
</div>

app/pods/containers/index/template.hbs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@
3838
<div class="text-muted">{{date-calendar container.created}}</div>
3939
</td>
4040
<td class="actions">
41-
{{resource-actions-menu model=container choices=container.availableActions}}
41+
{{#unless container.isManaged}}
42+
{{resource-actions-menu model=container choices=container.availableActions}}
43+
{{/unless}}
4244
</td>
4345
</tr>
4446
{{else}}

app/pods/containers/route.js

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,8 @@
11
import Ember from 'ember';
2-
import UnmanagedProxy from 'ui/utils/unmanaged-array-proxy';
32

43
export default Ember.Route.extend({
54
model: function() {
6-
return this.get('store').findAll('container').then((all) => {
7-
var proxy = UnmanagedProxy.create({
8-
sortProperties: ['name','id'],
9-
sourceContent: all
10-
});
11-
return proxy;
12-
});
5+
return this.get('store').findAll('container');
136
},
147

158
activate: function() {

app/pods/host/controller.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1+
import Ember from 'ember';
12
import Cattle from 'ui/utils/cattle';
23
import util from 'ui/utils/util';
3-
import UnmanagedProxy from 'ui/utils/unmanaged-array-proxy';
44

55
var HostController = Cattle.TransitioningResourceController.extend({
66
actions: {
@@ -82,12 +82,11 @@ var HostController = Cattle.TransitioningResourceController.extend({
8282
}.property('ipAddresses','ipAddresses.[]'),
8383

8484
arrangedInstances: function() {
85-
var filtered = UnmanagedProxy.create({
86-
sortProperties: ['name','id'],
87-
sourceContent: this.get('instances')
85+
return Ember.ArrayController.create({
86+
content: this.get('instances'),
87+
sortProperties: ['name','id']
8888
});
89-
return filtered;
90-
}.property('instances.@each.{name,id,systemContainer}'),
89+
}.property('instances.[]','instances.@each.{name,id}'),
9190

9291
machine: function() {
9392
var phid = this.get('physicalHostId');
Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,9 @@
11
import Ember from 'ember';
2-
import UnmanagedProxy from 'ui/utils/unmanaged-array-proxy';
32

43
export default Ember.ObjectController.extend({
54
actions: {
65
newContainer: function() {
76
this.transitionToRoute('containers.new', {queryParams: {hostId: this.get('id')}});
87
},
98
},
10-
11-
unmanagedInstances: function() {
12-
return UnmanagedProxy.create({
13-
sortProperties: ['name','id'],
14-
sourceContent: this.get('instances')
15-
});
16-
}.property()
179
});

app/pods/host/host-containers/template.hbs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<section class="grid-header">
22
<div class="row">
33
<div class="col-sm-6">
4-
<h3>Containers ({{unmanagedInstances.length}})</h3>
4+
<h3>Containers ({{instances.length}})</h3>
55
</div>
66
<div class="col-sm-6 text-right">
77
<button {{action "newContainer"}} class="btn btn-sm btn-primary">Add Container</button>
@@ -20,7 +20,7 @@
2020
</tr>
2121
</thead>
2222
<tbody>
23-
{{#each container in unmanagedInstances itemController="container"}}
23+
{{#each container in instances itemController="container"}}
2424
<tr>
2525
<td>
2626
<span {{bind-attr class=":badge :state container.stateBackground"}}>
@@ -37,7 +37,9 @@
3737
<div class="text-muted">{{date-calendar container.created}}</div>
3838
</td>
3939
<td class="actions">
40-
{{resource-actions-menu model=container choices=container.availableActions}}
40+
{{#unless container.isManaged}}
41+
{{resource-actions-menu model=container choices=container.availableActions}}
42+
{{/unless}}
4143
</td>
4244
</tr>
4345
{{else}}

app/styles/host.scss

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ $instance-ip: #9a9a9a;
221221
}
222222
}
223223

224-
.instance-ip {
224+
.instance-ip, .instance.managed A {
225225
color: $instance-ip;
226226
}
227227

@@ -269,7 +269,8 @@ $instance-ip: #9a9a9a;
269269
.touch .instance {
270270
padding-right: 31px;
271271

272-
&.add-container {
272+
&.add-container,
273+
&.managed {
273274
padding-right: 10px;
274275
}
275276
}

0 commit comments

Comments
 (0)