Bump node-sass to 8.0.0 (from 4.14.1) #5191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantis-toboggan-md
approved these changes
May 30, 2025
Member
mantis-toboggan-md
left a comment
mantis-toboggan-md
left a comment
There was a problem hiding this comment.
LGTM - I'm not seeing any style issues either
Member
Author
|
Won't fix ahead of removal of the legacy UI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps node-saas to 8.0.0 - this updates a number of sub-dependencies, which keeps us up to date.
The latest version is
9.0.0, but this drops support for Node 14, so we can not use it.I have checked the change log, and although these are major version bumps, going from 4 to 8, the breaking changes seem small and don't appear to affect things in our usage.
After update, I was able to test the UI and the styling still seemed to be correct.