ahhh okay I understand what's happening - solver_fee is actually both solver + verification fee in one, we never substract them: https://github.com/randa-mu/onlysubs-solidity/blob/bb2e7c8a3b3f2d44e112e84f53d9dee4d678f697/src/Router.sol#L141
Also, the verification fee looks fuuuucking high here - will check the maths
Originally posted by @CluEleSsUK in randa-mu/dcipher#141 (comment)
I'd suggest we rename the parameter the user passes as totalFee and just 'figure out' the solver fee (or add it as a new param with a slightly different name?). Backwards compatibility might be spicy
ahhh okay I understand what's happening -
solver_feeis actually both solver + verification fee in one, we never substract them: https://github.com/randa-mu/onlysubs-solidity/blob/bb2e7c8a3b3f2d44e112e84f53d9dee4d678f697/src/Router.sol#L141Also, the verification fee looks fuuuucking high here - will check the maths
Originally posted by @CluEleSsUK in randa-mu/dcipher#141 (comment)
I'd suggest we rename the parameter the user passes as
totalFeeand just 'figure out' the solver fee (or add it as a new param with a slightly different name?). Backwards compatibility might be spicy