feat(MockRandomnessSender)#26
Conversation
|
it's called rm receive but I meant to name the commit: rm fallback |
bbjubjub2494
left a comment
bbjubjub2494
left a comment
There was a problem hiding this comment.
Sorry for not getting distracted.
The CI failure is not your fault, see #28
The code by itself LGTM. Normally though, if I see a mock in a repo I would assume that it's being used by the tests, but that's not the case here. As a result it feels like we would be maintaining it mostly based on vibes, which is not so easy. That said I don't have a lot of context for the blackjack(?) project so I don't know what's planned.
Also paging Tari since he's more likely to be the one maintaining this stuff long term.
| /// @author Randamu | ||
| /// @notice Mock implementation of RandomnessSender for testing purposes | ||
| /// @dev This contract provides controllable randomness for testing smart contracts | ||
| contract MockRandomnessSender { |
There was a problem hiding this comment.
| contract MockRandomnessSender { | |
| contract MockRandomnessSender is IRandomnessSender { |
Is my understanding correct here? If so we seem to be missing 4 functions as well
The Mock is used for the tests, as you expected: no Mock should be deployed in production |
|
which tests? |
|
It is used in tests for everything integrating RandomnessSender : |
2 participants
Add MockRandomnessSender and its readme