Skip to content

Commit 1e49d18

Browse files
committed
Remove commented-out code and unused parameters
- Remove all commented helper functions that were not being used - Remove filters and settings parameters from KanbanViewProps interface - Update App.tsx to not pass unused props to KanbanView - All 49 tests still passing
1 parent 1bed215 commit 1e49d18

2 files changed

Lines changed: 1 addition & 39 deletions

File tree

src/renderer/App.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,10 @@ const App = (): JSX.Element => {
124124
{settings.viewMode === 'kanban' ? (
125125
<KanbanView
126126
todoData={todoData}
127-
filters={filters}
128127
setTodoObject={setTodoObject}
129128
setDialogOpen={setDialogOpen}
130129
setContextMenu={setContextMenu}
131130
setPromptItem={setPromptItem}
132-
settings={settings}
133131
/>
134132
) : (
135133
<GridComponent

src/renderer/Kanban/KanbanView.tsx

Lines changed: 1 addition & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@ const { ipcRenderer } = (window as any).api
99

1010
interface KanbanViewProps {
1111
todoData: TodoData
12-
filters: Filters | null
1312
setTodoObject: React.Dispatch<React.SetStateAction<TodoObject | null>>
1413
setDialogOpen: React.Dispatch<React.SetStateAction<boolean>>
1514
setContextMenu: React.Dispatch<React.SetStateAction<ContextMenu | null>>
1615
setPromptItem: React.Dispatch<React.SetStateAction<PromptItem | null>>
17-
settings: Settings
1816
}
1917

2018
interface KanbanColumn {
@@ -25,12 +23,10 @@ interface KanbanColumn {
2523

2624
const KanbanView: React.FC<KanbanViewProps> = ({
2725
todoData,
28-
// filters, // Removed unused parameter
2926
setTodoObject,
3027
setDialogOpen,
3128
setContextMenu,
32-
setPromptItem,
33-
// settings // Removed unused parameter
29+
setPromptItem
3430
}) => {
3531
const [columns, setColumns] = useState<KanbanColumn[]>([])
3632
const [draggedTodo, setDraggedTodo] = useState<TodoObject | null>(null)
@@ -302,38 +298,6 @@ const KanbanView: React.FC<KanbanViewProps> = ({
302298
})
303299
}
304300

305-
// const handleCloseContextMenu = () => {
306-
// setContextMenu(null)
307-
// }
308-
309-
// Helper functions for future use
310-
// const handleToggleComplete = (todo: TodoObject) => {
311-
// ipcRenderer.send('writeTodoToFile', todo.lineNumber, todo.string, !todo.complete, false)
312-
// handleCloseContextMenu()
313-
// }
314-
315-
// const handleDeleteTodo = (todo: TodoObject) => {
316-
// setPromptItem({
317-
// headline: 'Delete todo?',
318-
// body: todo.body || todo.string,
319-
// acceptFunction: () => {
320-
// ipcRenderer.send('removeLineFromFile', todo.lineNumber)
321-
// setPromptItem(null)
322-
// },
323-
// declineFunction: () => setPromptItem(null)
324-
// })
325-
// handleCloseContextMenu()
326-
// }
327-
328-
// const handleChangePriority = (todo: TodoObject, priority: string) => {
329-
// let updatedString = todo.string.replace(/^\([A-Z]\)\s*/, '')
330-
// if (priority) {
331-
// updatedString = `(${priority}) ${updatedString}`
332-
// }
333-
// ipcRenderer.send('writeTodoToFile', todo.lineNumber, updatedString, todo.complete, false)
334-
// handleCloseContextMenu()
335-
// }
336-
337301
const getPriorityColor = (priority: string | null): string => {
338302
if (!priority) return 'default'
339303
const priorityLetter = priority.toUpperCase()

0 commit comments

Comments
 (0)