Fix markdown links and event listener memory leak

Author: ransome1

src/main/IpcHandlers.ts

@@ -303,11 +303,16 @@ function handleRequestArchive(event: IpcMainEvent, lineNumber?: number): void {
 
 // ─── System handlers ─────────────────────────────────────────────────────
 
-function handleOpenInBrowser(_: IpcMainEvent, url: string): void {
+async function handleOpenInBrowser(
+  event: IpcMainEvent,
+  url: string,
+): Promise<void> {
   try {
-    shell.openExternal(url);
+    await shell.openExternal(url);
   } catch (error) {
-    if (error instanceof Error) HandleError(error);
+    if (error instanceof Error) {
+      event.reply("responseFromMainProcess", error);
+    }
   }
 }
 

src/renderer/Archive.tsx

@@ -1,4 +1,4 @@
-import React, { useEffect, useState } from "react";
+import React, { useEffect, useState, useCallback } from "react";
 import { useTranslation } from "react-i18next";
 import { PromptItem } from "@sleek-types";
 
@@ -18,63 +18,69 @@ const ArchiveComponent: React.FC<ArchiveComponentProps> = ({
     number | undefined
   >(undefined);
 
-  const handleArchiveAllConfirm = (): void => {
+  const handleArchiveAllConfirm = useCallback((): void => {
     ipcRenderer.send("archiveTodos");
-  };
+  }, []);
 
-  const handleArchiveSingleConfirm = (): void => {
+  const handleArchiveSingleConfirm = useCallback((): void => {
     ipcRenderer.send("archiveSingleTodo", archiveLineNumber);
-  };
+  }, [archiveLineNumber]);
 
-  const handleOpenDoneFile = (): void => {
+  const handleOpenDoneFile = useCallback((): void => {
     ipcRenderer.send("openFile", true, archiveLineNumber);
-  };
+  }, [archiveLineNumber]);
 
-  const handleCreateDoneFile = (): void => {
+  const handleCreateDoneFile = useCallback((): void => {
     ipcRenderer.send("createFile", true, archiveLineNumber);
-  };
-
-  const handleTriggerArchiving = (
-    doneFileAvailable: boolean,
-    lineNumber?: number,
-  ): void => {
-    setArchiveLineNumber(lineNumber);
-
-    // Define prompt items here to get fresh translations every time
-    const promptItemArchivingAll = {
-      id: "archive",
-      headline: t("prompt.archive.headline"),
-      text: t("prompt.archive.text"),
-      button1: t("archive"),
-      onButton1: handleArchiveAllConfirm,
-    };
-
-    const promptItemArchivingSingle = {
-      id: "archive",
-      headline: t("prompt.archive.headline.single"),
-      text: t("prompt.archive.text.single"),
-      button1: t("archive"),
-      onButton1: handleArchiveSingleConfirm,
-    };
-
-    const promptItemChooseChangeFile = {
-      id: "changeFile",
-      headline: t("prompt.archive.changeFile.headline"),
-      text: t("prompt.archive.changeFile.text"),
-      button1: t("openFile"),
-      onButton1: handleOpenDoneFile,
-      button2: t("createFile"),
-      onButton2: handleCreateDoneFile,
-    };
-
-    setPromptItem(
-      doneFileAvailable
-        ? lineNumber
-          ? promptItemArchivingSingle
-          : promptItemArchivingAll
-        : promptItemChooseChangeFile,
-    );
-  };
+  }, [archiveLineNumber]);
+
+  const handleTriggerArchiving = useCallback(
+    (doneFileAvailable: boolean, lineNumber?: number): void => {
+      setArchiveLineNumber(lineNumber);
+
+      // Define prompt items here to get fresh translations every time
+      const promptItemArchivingAll = {
+        id: "archive",
+        headline: t("prompt.archive.headline"),
+        text: t("prompt.archive.text"),
+        button1: t("archive"),
+        onButton1: handleArchiveAllConfirm,
+      };
+
+      const promptItemArchivingSingle = {
+        id: "archive",
+        headline: t("prompt.archive.headline.single"),
+        text: t("prompt.archive.text.single"),
+        button1: t("archive"),
+        onButton1: handleArchiveSingleConfirm,
+      };
+
+      const promptItemChooseChangeFile = {
+        id: "changeFile",
+        headline: t("prompt.archive.changeFile.headline"),
+        text: t("prompt.archive.changeFile.text"),
+        button1: t("openFile"),
+        onButton1: handleOpenDoneFile,
+        button2: t("createFile"),
+        onButton2: handleCreateDoneFile,
+      };
+
+      setPromptItem(
+        doneFileAvailable
+          ? lineNumber
+            ? promptItemArchivingSingle
+            : promptItemArchivingAll
+          : promptItemChooseChangeFile,
+      );
+    },
+    [
+      t,
+      handleArchiveAllConfirm,
+      handleArchiveSingleConfirm,
+      handleOpenDoneFile,
+      handleCreateDoneFile,
+    ],
+  );
 
   useEffect((): void => {
     if (triggerArchiving) {

src/renderer/Grid/Renderer.tsx

@@ -1,5 +1,5 @@
 import React, { JSX, memo } from "react";
-import ReactMarkdown, { Components } from "react-markdown";
+import ReactMarkdown, { Components, defaultUrlTransform } from "react-markdown";
 import remarkGfm from "remark-gfm";
 import Chip from "@mui/material/Chip";
 import { SnackbarAction } from "../../@types";
@@ -235,6 +235,15 @@ const RendererComponent: React.FC<RendererComponentProps> = memo(
       "custom-tag": (value) => <span>{value}</span>,
     };
 
+    const allowCustomProtocols = (url: string): string => {
+      // Allow file:// and other custom protocol URLs (joplin://, cbthunderlink://, etc.)
+      if (/^[a-zA-Z][a-zA-Z0-9+.-]*:\/\//i.test(url)) {
+        return url; // pass through all protocol URLs untouched
+      }
+      // Fall back to default security behavior for web URLs
+      return defaultUrlTransform(url);
+    };
+
     const options: Components = {
       p: ({ children }): JSX.Element | null => {
         const mappedChildren = React.Children.map(children, (child) => {
@@ -328,11 +337,13 @@ const RendererComponent: React.FC<RendererComponentProps> = memo(
         const childrenStr =
           typeof children === "string" ? children : String(children);
 
-        // Use href from destructure first, then fall back
-        // Treat empty strings as missing - trim whitespace and use if available
-        const href = hrefFromDestructure?.trim() || childrenStr;
+        // Use href from ReactMarkdown if available and non-empty.
+        // Otherwise extract a URL from the children text (bare URL case).
+        const urlInChildren =
+          /([a-zA-Z][a-zA-Z0-9+.-]*:\/\/\S+)/g.exec(childrenStr)?.[1] ?? null;
+        const href =
+          hrefFromDestructure?.trim() || urlInChildren || childrenStr;
 
-        const match = /([a-zA-Z]+:\/\/\S+)/g.exec(childrenStr);
         const maxChars = 40;
         const truncatedChildren =
           childrenStr.length > maxChars
@@ -343,9 +354,9 @@ const RendererComponent: React.FC<RendererComponentProps> = memo(
           <a
             {...restProps}
             href={href}
-            onClick={(event) =>
-              handleLinkClick(event, match ? childrenStr : href || childrenStr)
-            }
+            onClick={(event) => {
+              handleLinkClick(event, href);
+            }}
           >
             {truncatedChildren}
             <OpenInNewIcon />
@@ -372,7 +383,11 @@ const RendererComponent: React.FC<RendererComponentProps> = memo(
     };
 
     return (
-      <ReactMarkdown remarkPlugins={[remarkGfm]} components={options}>
+      <ReactMarkdown
+        remarkPlugins={[remarkGfm]}
+        components={options}
+        urlTransform={allowCustomProtocols}
+      >
         {preprocessBody(todoObject.body)}
       </ReactMarkdown>
     );