Land #20156, modules/post: Resolve RuboCop violations and typos

Land #20156, modules/post: Resolve RuboCop violations and typos

Author: dledda-r7

modules/post/firefox/gather/xss.rb

@@ -63,7 +63,7 @@ def js_payload
 
         hiddenWindow.location = 'about:blank';
         var src = (#{JSON.unparse({ src: js })}).src;
-        var key = "#{Rex::Text.rand_text_alphanumeric(rand(8..19))}";
+        var key = "#{Rex::Text.rand_text_alphanumeric(8..19)}";
 
         hiddenWindow[key] = true;
         hiddenWindow.location = "#{datastore['URL']}";

modules/post/linux/gather/f5_loot_mcp.rb

@@ -31,7 +31,7 @@ def initialize(info = {})
         ],
         'DisclosureDate' => '2022-11-16',
         'Notes' => {
-          'Stability' => [],
+          'Stability' => [CRASH_SAFE],
           'Reliability' => [],
           'SideEffects' => []
         }

modules/post/linux/gather/mimipenguin.rb

@@ -42,7 +42,7 @@ def initialize(info = {})
         'DisclosureDate' => '2018-05-23',
         'DefaultTarget' => 0,
         'Notes' => {
-          'Stability' => [],
+          'Stability' => [CRASH_SAFE],
           'Reliability' => [],
           'SideEffects' => []
         },

modules/post/linux/gather/rancher_audit_log_leak.rb

@@ -33,7 +33,7 @@ def initialize(info = {})
         ],
         'DisclosureDate' => '2024-02-08',
         'Notes' => {
-          'Stability' => [],
+          'Stability' => [CRASH_SAFE],
           'Reliability' => [],
           'SideEffects' => []
         }

modules/post/linux/manage/disable_clamav.rb

@@ -4,7 +4,6 @@
 ##
 
 class MetasploitModule < Msf::Post
-  Rank = ExcellentRanking
   include Msf::Post::File
   include Msf::Post::Unix
 

modules/post/multi/gather/dbeaver.rb

@@ -25,7 +25,7 @@ def initialize(info = {})
         'Platform' => [ 'linux', 'win', 'osx', 'unix'],
         'SessionTypes' => [ 'meterpreter', 'shell', 'powershell' ],
         'Notes' => {
-          'Stability' => [],
+          'Stability' => [CRASH_SAFE],
           'Reliability' => [],
           'SideEffects' => []
         }

modules/post/multi/gather/electerm.rb

@@ -24,7 +24,7 @@ def initialize(info = {})
         'Platform' => [ 'linux', 'win', 'osx', 'unix'],
         'SessionTypes' => [ 'meterpreter', 'shell', 'powershell' ],
         'Notes' => {
-          'Stability' => [],
+          'Stability' => [CRASH_SAFE],
           'Reliability' => [],
           'SideEffects' => []
         }

modules/post/multi/gather/firefox_creds.rb

@@ -118,7 +118,7 @@ def do_decrypt
 
     omnija = nil             # non meterpreter download
     org_file = 'omni.ja'     # key file
-    new_file = Rex::Text.rand_text_alpha(rand(5..7)) + '.ja'
+    new_file = Rex::Text.rand_text_alpha(5..7) + '.ja'
     temp_file = 'orgomni.ja' # backup of key file
 
     # Sets @paths

modules/post/multi/gather/minio_client.rb

@@ -21,7 +21,7 @@ def initialize(info = {})
         'Platform' => [ 'win', 'linux', 'osx', 'unix' ],
         'SessionTypes' => %w[meterpreter powershell shell],
         'Notes' => {
-          'Stability' => [],
+          'Stability' => [CRASH_SAFE],
           'Reliability' => [],
           'SideEffects' => []
         }

modules/post/multi/gather/wlan_geolocate.rb

@@ -229,7 +229,7 @@ def run
   rescue Rex::TimeoutError, Rex::Post::Meterpreter::RequestError => e
     vprint_error(e.message)
   rescue StandardError => e
-    print_status("The following Error was encountered: #{e.class} #{e}")
+    print_status("The following error was encountered: #{e.class} #{e}")
   end
 
 end

modules/post/multi/gather/wowza_streaming_engine_creds.rb

@@ -23,7 +23,7 @@ def initialize(info = {})
         'Platform' => %w[win linux osx unix],
         'SessionTypes' => %w[meterpreter powershell shell],
         'Notes' => {
-          'Stability' => [],
+          'Stability' => [CRASH_SAFE],
           'Reliability' => [],
           'SideEffects' => []
         }

modules/post/multi/general/close.rb

@@ -16,7 +16,7 @@ def initialize(info = {})
         'Platform' => %w[linux osx unix win],
         'SessionTypes' => [ 'shell', 'meterpreter' ],
         'Notes' => {
-          'Stability' => [],
+          'Stability' => [CRASH_SERVICE_DOWN],
           'SideEffects' => [],
           'Reliability' => []
         }

modules/post/multi/manage/screensaver.rb

@@ -22,6 +22,7 @@ def initialize(info = {})
         ],
         'Platform' => [ 'linux', 'osx', 'win', 'unix', 'solaris' ],
         'SessionTypes' => [ 'shell', 'meterpreter' ],
+        'DefaultAction' => 'LOCK',
         'Actions' => [
           [ 'LOCK', { 'Description' => 'Lock the current session' } ],
           [ 'UNLOCK', { 'Description' => 'Unlock the current session' } ],
@@ -33,8 +34,8 @@ def initialize(info = {})
         ],
         'Notes' => {
           'Reliability' => [ ],
-          'Stability' => [ ],
-          'SideEffects' => [ ]
+          'Stability' => [CRASH_SAFE],
+          'SideEffects' => [SCREEN_EFFECTS]
         }
       )
     )

modules/post/osx/gather/enum_keychain.rb

@@ -24,7 +24,7 @@ def initialize(info = {})
         'SessionTypes' => [ 'meterpreter', 'shell' ],
         'Notes' => {
           'Stability' => [CRASH_SAFE],
-          'SideEffects' => [ARTIFACTS_ON_DISK],
+          'SideEffects' => [ARTIFACTS_ON_DISK, SCREEN_EFFECTS],
           'Reliability' => []
         }
       )

modules/post/windows/gather/bloodhound.rb

@@ -25,7 +25,7 @@ def initialize(info = {})
         'Notes' => {
           'AKA' => ['sharphound'],
           'SideEffects' => [ARTIFACTS_ON_DISK],
-          'Stability' => [],
+          'Stability' => [CRASH_SAFE],
           'Reliability' => []
         }
       )

modules/post/windows/gather/credentials/moba_xterm.rb

@@ -28,7 +28,7 @@ def initialize(info = {})
         'Platform' => [ 'win' ],
         'SessionTypes' => [ 'meterpreter' ],
         'Notes' => {
-          'Stability' => [],
+          'Stability' => [CRASH_SAFE],
           'Reliability' => [],
           'SideEffects' => []
         },

modules/post/windows/gather/credentials/navicat.rb

@@ -11,12 +11,13 @@ class MetasploitModule < Msf::Post
   include Msf::Post::File
   # secret_key = Digest::SHA1.digest('3DC5CA39')
   SECRET_KEY = "B\xCE\xB2q\xA5\xE4X\xB7J\xEA\x93\x94y\"5C\x91\x873@".freeze
+
   def initialize(info = {})
     super(
       update_info(
         info,
         'Name' => 'Windows Gather Navicat Passwords',
-        'Description' => %q{ This module will find and decrypt stored Navicat passwords },
+        'Description' => %q{ This module will find and decrypt stored Navicat passwords. },
         'License' => MSF_LICENSE,
         'References' => [
           [ 'URL', 'https://github.com/HyperSine/how-does-navicat-encrypt-password'],
@@ -29,7 +30,7 @@ def initialize(info = {})
         'Platform' => [ 'win' ],
         'SessionTypes' => [ 'meterpreter', 'shell'],
         'Notes' => {
-          'Stability' => [],
+          'Stability' => [CRASH_SAFE],
           'Reliability' => [],
           'SideEffects' => []
         }

modules/post/windows/gather/credentials/securecrt.rb

@@ -30,7 +30,7 @@ def initialize(info = {})
         'SessionTypes' => [ 'meterpreter' ],
         'Notes' => {
           'Reliability' => [],
-          'Stability' => [],
+          'Stability' => [ CRASH_SAFE ],
           'SideEffects' => [ IOC_IN_LOGS ]
         },
         'Compat' => {

modules/post/windows/gather/credentials/viber.rb

@@ -35,7 +35,7 @@ class MetasploitModule < Msf::Post
           path: 'AppData',
           dir: 'ViberPC',
           artifact_file_name: '*.jpg',
-          description: 'Collects all images of contacts and sent recieved',
+          description: 'Collects all images of contacts and sent received',
           credential_type: 'image'
         }
       ]

modules/post/windows/gather/credentials/xchat.rb

@@ -19,7 +19,7 @@ class MetasploitModule < Msf::Post
           path: 'AppData',
           dir: 'X-Chat 2',
           artifact_file_name: '*.txt',
-          description: 'Collects all chatting conversations of sent and recieved',
+          description: 'Collects all chatting conversations of sent and received',
           credential_type: 'text',
           regex_search: [
             {

modules/post/windows/gather/forensics/recovery_files.rb

@@ -252,7 +252,7 @@ def go_over_mft(logc, offset, handle, files)
     end
   end
 
-  # Recieve the MFT data runs and list/save the deleted files
+  # Receive the MFT data runs and list/save the deleted files
   # Useful cheat_sheet to understand the MFT structure:  http://www.writeblocked.org/resources/ntfs_cheat_sheets.pdf
   # Recap of each of the attributes: http://runenordvik.com/doc/MFT-table.pdf
   def deleted_files(data_runs, handle, files)

modules/post/windows/manage/kerberos_tickets.rb

@@ -61,7 +61,7 @@ def initialize(info = {})
         ],
         'DefaultAction' => 'DUMP_TICKETS',
         'Notes' => {
-          'Stability' => [],
+          'Stability' => [CRASH_SAFE],
           'Reliability' => [],
           'SideEffects' => []
         },

modules/post/windows/wlan/wlan_current_connection.rb

@@ -189,7 +189,7 @@ def query_current_connection(wlan_handle, guid)
     signal = @host_process.memory.read(pointer, 4)
     connection['signal'] = signal.unpack('V')[0]
 
-    # Grabs the recieve rate value
+    # Grabs the receive rate value
     pointer = (pointer + 4)
     rxrate = @host_process.memory.read(pointer, 4)
     connection['rxrate'] = rxrate.unpack('V')[0]

modules/post/windows/wlan/wlan_disconnect.rb

@@ -225,7 +225,7 @@ def query_current_connection(wlan_handle, guid)
     signal = @host_process.memory.read(pointer, 4)
     connection['signal'] = signal.unpack('V')[0]
 
-    # Grabs the recieve rate value
+    # Grabs the receive rate value
     pointer = (pointer + 4)
     rxrate = @host_process.memory.read(pointer, 4)
     connection['rxrate'] = rxrate.unpack('V')[0]