Duplication in Exploit::Remote::Ftp and Rex::Proto::Ftp Libraries

[pingport80]

Summary

Currently both Exploit::Remote::Ftp and Rex::Proto::Ftp are defining same methods, which could be reduced if former uses the methods defined in the later.

Useful Links :
- Rex::Proto::Ftp
- Exploit::Remote::Ftp

Exploit::Remote::HttpClient mixin uses the core methods of HTTP protocol from Rex::Proto::Http::Client, but in case of FTP this is not happening which results in defining same methods in both the files.

Also none of the modules or other libraries are using Rex::Proto::Ftp.

[pingport80]

I would like to propose a library label for this issue.

[adfoster-r7]

Looks Rex::Proto::Ftp was was originally added with the intention of using it in the future: #8762

[pingport80]

Yeah, I went through the discussion and support for the rex::ftp was discussed to be added in the other two implementations of ftp, but that didn't happen I guess.

exploit::remote::ftp can take methods from rex::proto.
And also metasploit/framework/ftp/client.rb is used just in Login_Scanner::Ftp with almost the same methods.
Login_Scanner::Ftp can take methods from exploit::remote::ftp or rex (as per requirement) without the need of metasploit/framework/ftp/client.rb.