Skip to content

Commit ab69ce7

Browse files
authored
Uniform review model naming (#1098)
1 parent 2fe9429 commit ab69ce7

File tree

3 files changed

+24
-25
lines changed

3 files changed

+24
-25
lines changed

config/rapidez/models.php

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -30,26 +30,25 @@
3030
'product_option_type_title' => Rapidez\Core\Models\ProductOptionTypeTitle::class,
3131
'product_option_type_value' => Rapidez\Core\Models\ProductOptionTypeValue::class,
3232
'product_price' => Rapidez\Core\Models\ProductPrice::class,
33-
// TODO: the naming is mixed..
34-
'product_review' => Rapidez\Core\Models\Review::class,
35-
'product_review_summary' => Rapidez\Core\Models\ProductReviewSummary::class,
36-
'product_stock' => Rapidez\Core\Models\ProductStock::class,
37-
'product_super_link' => Rapidez\Core\Models\ProductSuperLink::class,
38-
'product_tier_price' => Rapidez\Core\Models\ProductTierPrice::class,
39-
'product_view' => Rapidez\Core\Models\ProductView::class,
40-
'quote' => Rapidez\Core\Models\Quote::class,
41-
'quote_id_mask' => Rapidez\Core\Models\QuoteIdMask::class,
42-
'quote_item' => Rapidez\Core\Models\QuoteItem::class,
43-
'quote_item_option' => Rapidez\Core\Models\QuoteItemOption::class,
44-
'report_event' => Rapidez\Core\Models\ReportEvent::class,
45-
'rewrite' => Rapidez\Core\Models\Rewrite::class,
46-
'sales_order' => Rapidez\Core\Models\SalesOrder::class,
47-
'sales_order_address' => Rapidez\Core\Models\SalesOrderAddress::class,
48-
'sales_order_item' => Rapidez\Core\Models\SalesOrderItem::class,
49-
'sales_order_payment' => Rapidez\Core\Models\SalesOrderPayment::class,
50-
'search_query' => Rapidez\Core\Models\SearchQuery::class,
51-
'search_synonym' => Rapidez\Core\Models\SearchSynonym::class,
52-
'store' => Rapidez\Core\Models\Store::class,
53-
'super_attribute' => Rapidez\Core\Models\SuperAttribute::class,
54-
'widget' => Rapidez\Core\Models\Widget::class,
33+
'product_stock' => Rapidez\Core\Models\ProductStock::class,
34+
'product_super_link' => Rapidez\Core\Models\ProductSuperLink::class,
35+
'product_tier_price' => Rapidez\Core\Models\ProductTierPrice::class,
36+
'product_view' => Rapidez\Core\Models\ProductView::class,
37+
'quote' => Rapidez\Core\Models\Quote::class,
38+
'quote_id_mask' => Rapidez\Core\Models\QuoteIdMask::class,
39+
'quote_item' => Rapidez\Core\Models\QuoteItem::class,
40+
'quote_item_option' => Rapidez\Core\Models\QuoteItemOption::class,
41+
'report_event' => Rapidez\Core\Models\ReportEvent::class,
42+
'review' => Rapidez\Core\Models\Review::class,
43+
'review_summary' => Rapidez\Core\Models\ReviewSummary::class,
44+
'rewrite' => Rapidez\Core\Models\Rewrite::class,
45+
'sales_order' => Rapidez\Core\Models\SalesOrder::class,
46+
'sales_order_address' => Rapidez\Core\Models\SalesOrderAddress::class,
47+
'sales_order_item' => Rapidez\Core\Models\SalesOrderItem::class,
48+
'sales_order_payment' => Rapidez\Core\Models\SalesOrderPayment::class,
49+
'search_query' => Rapidez\Core\Models\SearchQuery::class,
50+
'search_synonym' => Rapidez\Core\Models\SearchSynonym::class,
51+
'store' => Rapidez\Core\Models\Store::class,
52+
'super_attribute' => Rapidez\Core\Models\SuperAttribute::class,
53+
'widget' => Rapidez\Core\Models\Widget::class,
5554
];

src/Models/Product.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,15 +193,15 @@ public function options(): HasMany
193193
public function reviewSummary(): HasOne
194194
{
195195
return $this->hasOne(
196-
config('rapidez.models.product_review_summary'),
196+
config('rapidez.models.review_summary', ReviewSummary::class),
197197
'entity_pk_value'
198198
);
199199
}
200200

201201
public function reviews(): BelongsToMany
202202
{
203203
return $this->belongsToMany(
204-
config('rapidez.models.product_review', Review::class), 'review',
204+
config('rapidez.models.review', Review::class), 'review',
205205
'entity_pk_value', 'review_id',
206206
'entity_id', 'review_id',
207207
)->where('review.entity_id', Review::REVIEW_ENTITY_PRODUCT);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use Illuminate\Database\Eloquent\Builder;
66
use Illuminate\Database\Eloquent\Relations\BelongsTo;
77

8-
class ProductReviewSummary extends Model
8+
class ReviewSummary extends Model
99
{
1010
protected $table = 'review_entity_summary';
1111

0 commit comments

Comments
 (0)