Skip to content

Commit 7065123

Browse files
authored
Fix forwarding of initial_alpha and learning_rate in UMAP (#6417)
Previously these parameters weren't fully forwarded properly to `libcuml`. Split out from #6316 (thanks Victor!) Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Simon Adorf (https://github.com/csadorf) URL: #6417
1 parent 0426c9a commit 7065123

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

python/cuml/cuml/manifold/simpl_set.pyx

+2-1
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,8 @@ def simplicial_set_embedding(
326326

327327
cdef UMAPParams* umap_params = new UMAPParams()
328328
umap_params.n_components = <int> n_components
329-
umap_params.initial_alpha = <int> initial_alpha
329+
umap_params.initial_alpha = <float> initial_alpha
330+
umap_params.learning_rate = <float> initial_alpha
330331
umap_params.a = <float> a
331332
umap_params.b = <float> b
332333

python/cuml/cuml/manifold/umap.pyx

+1
Original file line numberDiff line numberDiff line change
@@ -470,6 +470,7 @@ class UMAP(UniversalBase,
470470
umap_params.n_components = <int> self.n_components
471471
umap_params.n_epochs = <int> self.n_epochs if self.n_epochs else 0
472472
umap_params.learning_rate = <float> self.learning_rate
473+
umap_params.initial_alpha = <float> self.learning_rate
473474
umap_params.min_dist = <float> self.min_dist
474475
umap_params.spread = <float> self.spread
475476
umap_params.set_op_mix_ratio = <float> self.set_op_mix_ratio

0 commit comments

Comments
 (0)