Skip to content

Commit 9581b0d

Browse files
committed
Temporarily skip all xgboost tests
1 parent abdba02 commit 9581b0d

File tree

4 files changed

+26
-0
lines changed

4 files changed

+26
-0
lines changed

python/cuml/cuml/tests/experimental/test_filex.py

+8
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ def _build_and_save_xgboost(
135135
)
136136
@pytest.mark.parametrize("n_classes", [2, 5, 25])
137137
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
138+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
138139
def test_fil_classification(
139140
train_device,
140141
infer_device,
@@ -229,6 +230,7 @@ def test_fil_classification(
229230
"max_depth", [unit_param(3), unit_param(7), stress_param(11)]
230231
)
231232
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
233+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
232234
def test_fil_regression(
233235
train_device,
234236
infer_device,
@@ -511,6 +513,7 @@ def small_classifier_and_preds(tmpdir_factory, request):
511513
@pytest.mark.parametrize("infer_device", ("cpu", "gpu"))
512514
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
513515
@pytest.mark.parametrize("precision", ["native", "float32", "float64"])
516+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
514517
def test_precision_xgboost(
515518
train_device, infer_device, precision, small_classifier_and_preds
516519
):
@@ -536,6 +539,7 @@ def test_precision_xgboost(
536539
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
537540
@pytest.mark.parametrize("layout", ["depth_first", "breadth_first", "layered"])
538541
@pytest.mark.parametrize("chunk_size", [2, 4, 8, 16, 32])
542+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
539543
def test_performance_hyperparameters(
540544
train_device, infer_device, layout, chunk_size, small_classifier_and_preds
541545
):
@@ -562,6 +566,7 @@ def test_performance_hyperparameters(
562566
@pytest.mark.parametrize("train_device", ("cpu", "gpu"))
563567
@pytest.mark.parametrize("infer_device", ("cpu", "gpu"))
564568
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
569+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
565570
def test_output_args(train_device, infer_device, small_classifier_and_preds):
566571
with using_device_type(train_device):
567572
model_path, model_type, X, xgb_preds = small_classifier_and_preds
@@ -722,6 +727,7 @@ def test_lightgbm(
722727
@pytest.mark.parametrize("n_classes", [2, 5, 25])
723728
@pytest.mark.parametrize("num_boost_round", [10, 100])
724729
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
730+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
725731
def test_predict_per_tree(
726732
train_device, infer_device, n_classes, num_boost_round, tmp_path
727733
):
@@ -783,6 +789,7 @@ def test_predict_per_tree(
783789
@pytest.mark.parametrize("infer_device", ("cpu", "gpu"))
784790
@pytest.mark.parametrize("n_classes", [5, 25])
785791
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
792+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
786793
def test_predict_per_tree_with_vector_leaf(
787794
train_device, infer_device, n_classes, tmp_path
788795
):
@@ -829,6 +836,7 @@ def test_predict_per_tree_with_vector_leaf(
829836
@pytest.mark.parametrize("infer_device", ("cpu", "gpu"))
830837
@pytest.mark.parametrize("n_classes", [2, 5, 25])
831838
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
839+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
832840
def test_apply(train_device, infer_device, n_classes, tmp_path):
833841
n_rows = 1000
834842
n_columns = 30

python/cuml/cuml/tests/explainer/test_gpu_treeshap.py

+5
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ def count_categorical_split(tl_model):
149149
],
150150
)
151151
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
152+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
152153
@pytest.mark.skipif(not has_shap(), reason="need to install shap")
153154
@pytest.mark.skipif(not has_sklearn(), reason="need to install scikit-learn")
154155
def test_xgb_regressor(objective):
@@ -223,6 +224,7 @@ def test_xgb_regressor(objective):
223224
],
224225
)
225226
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
227+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
226228
@pytest.mark.skipif(not has_shap(), reason="need to install shap")
227229
@pytest.mark.skipif(not has_sklearn(), reason="need to install scikit-learn")
228230
def test_xgb_classifier(objective, n_classes):
@@ -478,6 +480,7 @@ def test_sklearn_rf_classifier(n_classes):
478480

479481

480482
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
483+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
481484
def test_xgb_toy_categorical():
482485
X = pd.DataFrame(
483486
{
@@ -511,6 +514,7 @@ def test_xgb_toy_categorical():
511514

512515
@pytest.mark.parametrize("n_classes", [2, 3])
513516
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
517+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
514518
@pytest.mark.skipif(not has_sklearn(), reason="need to install scikit-learn")
515519
def test_xgb_classifier_with_categorical(n_classes):
516520
n_samples = 100
@@ -572,6 +576,7 @@ def test_xgb_classifier_with_categorical(n_classes):
572576

573577

574578
@pytest.mark.skipif(not has_xgboost(), reason="need to install xgboost")
579+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
575580
@pytest.mark.skipif(not has_sklearn(), reason="need to install scikit-learn")
576581
def test_xgb_regressor_with_categorical():
577582
n_samples = 100

python/cuml/cuml/tests/test_benchmark.py

+4
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,10 @@ def test_real_algos_runner(algo_name):
195195
):
196196
pytest.xfail()
197197

198+
# TODO(hcho3): Remove once XGBoost works with older drivers
199+
if algo_name == "FIL":
200+
pytest.xfail(reason="xgboost's allocator doesn't work with older drivers")
201+
198202
runner = AccuracyComparisonRunner(
199203
[50], [5], dataset_name="classification", test_fraction=0.20
200204
)

python/cuml/cuml/tests/test_fil.py

+9
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ def _build_and_save_xgboost(
133133
)
134134
@pytest.mark.parametrize("n_classes", [2, 5, 25])
135135
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
136+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
136137
@pytest.mark.filterwarnings("ignore::FutureWarning")
137138
def test_fil_classification(
138139
n_rows, n_columns, num_rounds, n_classes, tmp_path
@@ -205,6 +206,7 @@ def test_fil_classification(
205206
"max_depth", [unit_param(3), unit_param(7), stress_param(11)]
206207
)
207208
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
209+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
208210
@pytest.mark.filterwarnings("ignore::FutureWarning")
209211
def test_fil_regression(n_rows, n_columns, num_rounds, tmp_path, max_depth):
210212
# settings
@@ -469,6 +471,7 @@ def small_classifier_and_preds(tmpdir_factory, request):
469471

470472

471473
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
474+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
472475
@pytest.mark.parametrize(
473476
"algo",
474477
[
@@ -501,6 +504,7 @@ def test_output_algos(algo, small_classifier_and_preds):
501504

502505

503506
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
507+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
504508
@pytest.mark.parametrize("precision", ["native", "float32", "float64"])
505509
@pytest.mark.filterwarnings("ignore::FutureWarning")
506510
def test_precision_xgboost(precision, small_classifier_and_preds):
@@ -521,6 +525,7 @@ def test_precision_xgboost(precision, small_classifier_and_preds):
521525

522526

523527
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
528+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
524529
@pytest.mark.parametrize(
525530
"storage_type", [False, True, "auto", "dense", "sparse", "sparse8"]
526531
)
@@ -543,6 +548,7 @@ def test_output_storage_type(storage_type, small_classifier_and_preds):
543548

544549

545550
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
551+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
546552
@pytest.mark.parametrize("storage_type", ["dense", "sparse"])
547553
@pytest.mark.parametrize("blocks_per_sm", [1, 2, 3, 4])
548554
@pytest.mark.filterwarnings("ignore::FutureWarning")
@@ -567,6 +573,7 @@ def test_output_blocks_per_sm(
567573

568574

569575
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
576+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
570577
@pytest.mark.parametrize("threads_per_tree", [2, 4, 8, 16, 32, 64, 128, 256])
571578
@pytest.mark.filterwarnings("ignore::FutureWarning")
572579
def test_threads_per_tree(threads_per_tree, small_classifier_and_preds):
@@ -594,6 +601,7 @@ def test_threads_per_tree(threads_per_tree, small_classifier_and_preds):
594601

595602
@pytest.mark.parametrize("output_class", [True, False])
596603
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
604+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
597605
@pytest.mark.filterwarnings("ignore::FutureWarning")
598606
def test_thresholding(output_class, small_classifier_and_preds):
599607
model_path, model_type, X, xgb_preds = small_classifier_and_preds
@@ -612,6 +620,7 @@ def test_thresholding(output_class, small_classifier_and_preds):
612620

613621

614622
@pytest.mark.skipif(has_xgboost() is False, reason="need to install xgboost")
623+
@pytest.mark.xfail(reason="xgboost's allocator doesn't work with older drivers")
615624
@pytest.mark.filterwarnings("ignore::FutureWarning")
616625
def test_output_args(small_classifier_and_preds):
617626
model_path, model_type, X, xgb_preds = small_classifier_and_preds

0 commit comments

Comments
 (0)