Commit e3af4cd
authored
Remove
This property, add to rmm in rapidsai/rmm#2317 and used in cuvs in #1931, is a holdover from when rmm enforced linking of dynamic cudart. rapidsai/rmm#2375 switched to static cudart and stopped querying the property, so remove it.
Also update Java bindings to explicitly load cudart now that it's not being pulled in as an indirect dependency.
Issue: rapidsai/build-planning#235
Authors:
- Kyle Edwards (https://github.com/KyleFromNVIDIA)
- Artem M. Chirkin (https://github.com/achirkin)
Approvers:
- Bradley Dice (https://github.com/bdice)
- Corey J. Nolet (https://github.com/cjnolet)
URL: #2065NO_CUDART_DEP property (#2065)1 parent 49c3037 commit e3af4cd
3 files changed
Lines changed: 11 additions & 16 deletions
File tree
- cpp
- java
- cuvs-java/src/main/java22/com/nvidia/cuvs/internal/common
- panama-bindings
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1027 | 1027 | | |
1028 | 1028 | | |
1029 | 1029 | | |
1030 | | - | |
1031 | | - | |
| 1030 | + | |
| 1031 | + | |
1032 | 1032 | | |
1033 | 1033 | | |
1034 | 1034 | | |
1035 | 1035 | | |
1036 | 1036 | | |
1037 | | - | |
1038 | | - | |
1039 | | - | |
1040 | | - | |
1041 | | - | |
1042 | | - | |
| 1037 | + | |
| 1038 | + | |
1043 | 1039 | | |
1044 | | - | |
1045 | 1040 | | |
1046 | 1041 | | |
1047 | 1042 | | |
| |||
1089 | 1084 | | |
1090 | 1085 | | |
1091 | 1086 | | |
1092 | | - | |
1093 | | - | |
| 1087 | + | |
| 1088 | + | |
1094 | 1089 | | |
1095 | 1090 | | |
1096 | 1091 | | |
1097 | 1092 | | |
1098 | | - | |
1099 | | - | |
| 1093 | + | |
1100 | 1094 | | |
1101 | 1095 | | |
1102 | 1096 | | |
1103 | 1097 | | |
1104 | 1098 | | |
1105 | 1099 | | |
1106 | | - | |
1107 | 1100 | | |
1108 | 1101 | | |
1109 | 1102 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
0 commit comments