be safer when constructing command args

Author: trxcllnt

features/src/rapids-build-utils/install.sh

@@ -96,10 +96,13 @@ done
 
 # Install bash_completion script
 if command -v devcontainer-utils-generate-bash-completion >/dev/null 2>&1; then
-    devcontainer-utils-generate-bash-completion                          \
-        --out-file /etc/bash_completion.d/rapids-build-utils-completions \
-        ${commands[@]/#/--command rapids-}                               \
-    ;
+    read -ra commands <<< "${commands[*]/#/--command rapids-}";
+    if test "${#commands[@]}" -gt 0; then
+        devcontainer-utils-generate-bash-completion                          \
+            --out-file /etc/bash_completion.d/rapids-build-utils-completions \
+            "${commands[@]}"                                                 \
+        ;
+    fi
 fi
 
 find /opt/rapids-build-utils \

features/src/rapids-build-utils/opt/rapids-build-utils/bin/generate-scripts.sh

@@ -17,12 +17,15 @@ generate_completions() {
         . devcontainer-utils-debug-output 'rapids_build_utils_debug' 'generate-scripts';
 
         readarray -t commands < <(find "${TMP_SCRIPT_DIR}"/ -maxdepth 1 -type f -exec basename {} \;);
-
-        devcontainer-utils-generate-bash-completion          \
-            --out-file "$(realpath -m "${COMPLETION_FILE}")" \
-            --template "$(realpath -m "${COMPLETION_TMPL}")" \
-            ${commands[@]/#/--command }                      \
-        ;
+        read -ra commands <<< "${commands[*]/#/--command }";
+
+        if test "${#commands[@]}" -gt 0; then
+            devcontainer-utils-generate-bash-completion          \
+                --out-file "$(realpath -m "${COMPLETION_FILE}")" \
+                --template "$(realpath -m "${COMPLETION_TMPL}")" \
+                "${commands[@]}"                                 \
+            ;
+        fi
     fi
 }
 

features/src/utils/install.sh

@@ -125,10 +125,13 @@ done
 declare -a commands="($(for pair in "${commands_and_sources[@]}"; do cut -d' ' -f1 <<< "${pair}"; done))";
 
 # Install bash_completion script
-devcontainer-utils-generate-bash-completion                          \
-    --out-file /etc/bash_completion.d/devcontainer-utils-completions \
-    ${commands[@]/#/--command devcontainer-utils-}                   \
-;
+read -ra commands <<< "${commands[*]/#/--command devcontainer-utils-}";
+if test "${#commands[@]}" -gt 0; then
+    devcontainer-utils-generate-bash-completion                          \
+        --out-file /etc/bash_completion.d/devcontainer-utils-completions \
+        "${commands[@]}"                                                 \
+    ;
+fi
 
 find /opt/devcontainer \
     \( -type d -exec chmod 0775 {} \; \