Skip to content

[FEA] add tests on image characteristics #667

Closed
@jameslamb

Description

@jameslamb

Is your feature request related to a problem? Please describe.

Images published from this repo are intended for use in a wide variety of contexts. For example, they're used in several different cloud providers' bring-your-own container solutions (see https://docs.rapids.ai/deployment/stable/).

Those environments each have slightly different requirements for images you bring to them... things like default user, exposed ports, expected filepaths, etc.

When changes like #449 are made to modify the images here, there are currently not strong automatic protections against accidental regressions.

This issue proposes adding such protections, to improve release confidence and hopefully catch some types of issues during development instead of further downstream.

Describe the solution you'd like

I'm proposing the following:

  • on every commit to PRs or main here, test all built images with container-canary (https://github.com/NVIDIA/container-canary), with the following tests:
  • on every commit to PRs, test files in this repo with some static analyzers. For example:
    • hadolint for Dockerfiles (link)
    • shellcheck for shell scripts (link)
    • ruff for Python code (link)

Describe alternatives you've considered

N/A

Additional context

This proposal comes out of mine and @jacobtomlinson 's discussions around this: rapidsai/deployment#277

And would help with stuff like this:

I'd be happy to come do the work, just looking for a 👍🏻 / 👎🏻 on the general idea (cc @raydouglass @ajschmidt8 @AyodeAwe )

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions